You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
We would like to see the tag partially-approved only when branch protection's request is not met.
Right now, the code also checks if everyone requested has approved it. The combination of CODEOWNER file and our flow, we tend to over-request for reviews, making it impossible for some PR to attain the proper approved tag.
Describe the solution you'd like
I would like to remove the second portion of this code, numRequestedReviewsRemaining > 0. If this is approved and people agree with this, I can submit PR to update this feature.
Describe alternatives you've considered
Offer it as a configuration option.
Additional context
I would also like to hear @allout58 's thoughts on this since this is their feature.
Is your feature request related to a problem? Please describe.
We would like to see the tag
partially-approvedonly when branch protection's request is not met.Right now, the code also checks if everyone requested has approved it. The combination of CODEOWNER file and our flow, we tend to over-request for reviews, making it impossible for some PR to attain the proper
approvedtag.Describe the solution you'd like
I would like to remove the second portion of this code,
numRequestedReviewsRemaining > 0. If this is approved and people agree with this, I can submit PR to update this feature.Describe alternatives you've considered
Offer it as a configuration option.
Additional context
I would also like to hear @allout58 's thoughts on this since this is their feature.