From a6cdc06ad1f36c14d4f7592ef0811b38baf5359c Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Tue, 30 Jun 2026 10:15:53 -0700 Subject: [PATCH] Remove unused ViewShadowNodeProps subclass (#57377) Summary: ViewShadowNodeProps was a thin subclass of ViewProps that only forwarded its constructor. After the feature flag propagation logic was removed, the subclass serves no purpose. Changelog: [Internal] Differential Revision: D110095190 --- .../components/view/ViewShadowNode.cpp | 6 --- .../renderer/components/view/ViewShadowNode.h | 14 +------ .../view/YogaLayoutableShadowNode.cpp | 3 +- .../components/view/tests/LayoutTest.cpp | 10 ++--- .../components/view/tests/ViewTest.cpp | 19 +++++----- .../core/tests/FindNodeAtPointTest.cpp | 14 +++---- .../core/tests/LayoutableShadowNodeTest.cpp | 38 +++++++++---------- .../renderer/element/tests/ElementTest.cpp | 6 +-- .../tests/DifferentiatorUnflattenTest.cpp | 2 +- .../mounting/tests/OrderIndexTest.cpp | 2 +- .../tests/ShadowTreeLifeCycleTest.cpp | 2 +- .../mounting/tests/StackingContextTest.cpp | 2 +- .../tests/FindShadowNodeByTagTest.cpp | 2 +- .../tests/PointerEventsProcessorTest.cpp | 8 ++-- .../api-snapshots/ReactAndroidDebugCxx.api | 8 +--- .../api-snapshots/ReactAndroidNewarchCxx.api | 8 +--- .../api-snapshots/ReactAndroidReleaseCxx.api | 8 +--- .../api-snapshots/ReactAppleDebugCxx.api | 8 +--- .../api-snapshots/ReactAppleNewarchCxx.api | 8 +--- .../api-snapshots/ReactAppleReleaseCxx.api | 8 +--- .../api-snapshots/ReactCommonDebugCxx.api | 8 +--- .../api-snapshots/ReactCommonNewarchCxx.api | 8 +--- .../api-snapshots/ReactCommonReleaseCxx.api | 8 +--- 23 files changed, 73 insertions(+), 127 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.cpp b/packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.cpp index af30883b21f..a166a90546c 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.cpp +++ b/packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.cpp @@ -14,12 +14,6 @@ namespace facebook::react { // NOLINTNEXTLINE(facebook-hte-CArray,modernize-avoid-c-arrays) const char ViewComponentName[] = "View"; -ViewShadowNodeProps::ViewShadowNodeProps( - const PropsParserContext& context, - const ViewShadowNodeProps& sourceProps, - const RawProps& rawProps) - : ViewProps(context, sourceProps, rawProps) {}; - ViewShadowNode::ViewShadowNode( const ShadowNodeFragment& fragment, const ShadowNodeFamily::Shared& family, diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.h b/packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.h index b3195934440..bc1a94e52ed 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.h +++ b/packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.h @@ -15,22 +15,12 @@ namespace facebook::react { // NOLINTNEXTLINE(modernize-avoid-c-arrays) extern const char ViewComponentName[]; -/** - * Implementation of the ViewProps that propagates feature flag. - */ -class ViewShadowNodeProps final : public ViewProps { - public: - ViewShadowNodeProps() = default; - ViewShadowNodeProps( - const PropsParserContext &context, - const ViewShadowNodeProps &sourceProps, - const RawProps &rawProps); -}; +using ViewShadowNodeProps = ViewProps; /* * `ShadowNode` for component. */ -class ViewShadowNode final : public ConcreteViewShadowNode { +class ViewShadowNode final : public ConcreteViewShadowNode { public: ViewShadowNode(const ShadowNodeFragment &fragment, const ShadowNodeFamily::Shared &family, ShadowNodeTraits traits); diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp b/packages/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp index f7adbe14ef6..ebe98db8eb4 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp +++ b/packages/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp @@ -1017,8 +1017,7 @@ void YogaLayoutableShadowNode::swapLeftAndRightInYogaStyleProps() { void YogaLayoutableShadowNode::swapLeftAndRightInViewProps() { if (auto viewShadowNode = dynamic_cast(this)) { // TODO: Do not mutate props directly. - auto& props = - const_cast(viewShadowNode->getConcreteProps()); + auto& props = const_cast(viewShadowNode->getConcreteProps()); // Swap border node values, borderRadii, borderColors and borderStyles. if (props.borderRadii.topLeft.has_value()) { diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/tests/LayoutTest.cpp b/packages/react-native/ReactCommon/react/renderer/components/view/tests/LayoutTest.cpp index a5a24224d08..c8c2c58ef07 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/tests/LayoutTest.cpp +++ b/packages/react-native/ReactCommon/react/renderer/components/view/tests/LayoutTest.cpp @@ -86,7 +86,7 @@ class LayoutTest : public ::testing::Test { .reference(viewShadowNodeA_) .tag(2) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; auto &yogaStyle = props.yogaStyle; yogaStyle.setPositionType(yoga::PositionType::Absolute); @@ -99,7 +99,7 @@ class LayoutTest : public ::testing::Test { .reference(viewShadowNodeAB_) .tag(3) .props([=] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; auto &yogaStyle = props.yogaStyle; yogaStyle.setPositionType(yoga::PositionType::Absolute); @@ -127,7 +127,7 @@ class LayoutTest : public ::testing::Test { .reference(viewShadowNodeABC_) .tag(4) .props([=] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; auto &yogaStyle = props.yogaStyle; @@ -147,7 +147,7 @@ class LayoutTest : public ::testing::Test { .reference(viewShadowNodeABCD_) .tag(5) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; auto &yogaStyle = props.yogaStyle; yogaStyle.setPositionType(yoga::PositionType::Absolute); @@ -162,7 +162,7 @@ class LayoutTest : public ::testing::Test { .reference(viewShadowNodeABE_) .tag(6) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; auto &yogaStyle = props.yogaStyle; yogaStyle.setPositionType(yoga::PositionType::Absolute); diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/tests/ViewTest.cpp b/packages/react-native/ReactCommon/react/renderer/components/view/tests/ViewTest.cpp index e9aa7b30eff..1fa9d32e15c 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/tests/ViewTest.cpp +++ b/packages/react-native/ReactCommon/react/renderer/components/view/tests/ViewTest.cpp @@ -51,7 +51,7 @@ class YogaDirtyFlagTest : public ::testing::Test { /* * Some non-default props. */ - auto mutableViewProps = std::make_shared(); + auto mutableViewProps = std::make_shared(); auto &props = *mutableViewProps; props.nativeId = "native Id"; props.opacity = 0.5; @@ -113,7 +113,7 @@ TEST_F(YogaDirtyFlagTest, changingNonLayoutSubPropsMustNotDirtyYogaNode) { */ auto newRootShadowNode = rootShadowNode_->cloneTree( innerShadowNode_->getFamily(), [](const ShadowNode& oldShadowNode) { - auto viewProps = std::make_shared(); + auto viewProps = std::make_shared(); auto& props = *viewProps; props.nativeId = "some new native Id"; @@ -136,7 +136,7 @@ TEST_F(YogaDirtyFlagTest, changingLayoutSubPropsMustDirtyYogaNode) { */ auto newRootShadowNode = rootShadowNode_->cloneTree( innerShadowNode_->getFamily(), [](const ShadowNode& oldShadowNode) { - auto viewProps = std::make_shared(); + auto viewProps = std::make_shared(); auto& props = *viewProps; props.yogaStyle.setAlignContent(yoga::Align::Baseline); @@ -243,7 +243,7 @@ TEST_F(YogaDirtyFlagTest, clonedPropsPreserveAspectRatio) { auto newRootShadowNode = rootShadowNode_->cloneTree( innerShadowNode_->getFamily(), [&](const ShadowNode& oldShadowNode) { // First clone: set aspectRatio to 1.5 - auto viewProps = std::make_shared(); + auto viewProps = std::make_shared(); viewProps->yogaStyle.setAspectRatio(yoga::FloatOptional(1.5f)); auto nodeWithAspectRatio = oldShadowNode.clone(ShadowNodeFragment{.props = viewProps}); @@ -255,8 +255,7 @@ TEST_F(YogaDirtyFlagTest, clonedPropsPreserveAspectRatio) { auto clonedProps = componentDescriptor.cloneProps( parserContext, nodeWithAspectRatio->getProps(), RawProps()); - auto& clonedViewProps = - static_cast(*clonedProps); + auto& clonedViewProps = static_cast(*clonedProps); EXPECT_TRUE(clonedViewProps.yogaStyle.aspectRatio().isDefined()); EXPECT_EQ(clonedViewProps.yogaStyle.aspectRatio().unwrap(), 1.5f); @@ -303,7 +302,7 @@ class YogaCloneTest : public ::testing::Test { .reference(parentShadowNode_) .tag(2) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; auto &yogaStyle = props.yogaStyle; yogaStyle.setFlexDirection(yoga::FlexDirection::Row); @@ -320,7 +319,7 @@ class YogaCloneTest : public ::testing::Test { .reference(childAShadowNode_) .tag(3) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->yogaStyle.setDimension( yoga::Dimension::Width, yoga::StyleSizeLength::points(100)); @@ -333,7 +332,7 @@ class YogaCloneTest : public ::testing::Test { .reference(childBShadowNode_) .tag(4) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->yogaStyle.setDimension( yoga::Dimension::Width, yoga::StyleSizeLength::points(100)); @@ -346,7 +345,7 @@ class YogaCloneTest : public ::testing::Test { .reference(childCShadowNode_) .tag(5) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->yogaStyle.setDimension( yoga::Dimension::Width, yoga::StyleSizeLength::points(100)); diff --git a/packages/react-native/ReactCommon/react/renderer/core/tests/FindNodeAtPointTest.cpp b/packages/react-native/ReactCommon/react/renderer/core/tests/FindNodeAtPointTest.cpp index ea14d216265..c3438eda1bd 100644 --- a/packages/react-native/ReactCommon/react/renderer/core/tests/FindNodeAtPointTest.cpp +++ b/packages/react-native/ReactCommon/react/renderer/core/tests/FindNodeAtPointTest.cpp @@ -126,7 +126,7 @@ TEST(FindNodeAtPointTest, viewIsScaled) { Element() .tag(3) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->transform = Transform::Scale(0.5, 0.5, 0); return sharedProps; }) @@ -199,7 +199,7 @@ TEST(FindNodeAtPointTest, overlappingViewsWithZIndex) { Element() .tag(2) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->zIndex = 1; auto &yogaStyle = sharedProps->yogaStyle; yogaStyle.setPositionType(yoga::PositionType::Absolute); @@ -235,7 +235,7 @@ TEST(FindNodeAtPointTest, overlappingViewsWithParentPointerEventsBoxOnly) { Element() .tag(1) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->pointerEvents = PointerEventsMode::BoxOnly; return sharedProps; }) @@ -277,7 +277,7 @@ TEST(FindNodeAtPointTest, overlappingViewsWithParentPointerEventsBoxNone) { Element() .tag(1) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->pointerEvents = PointerEventsMode::BoxNone; return sharedProps; }) @@ -290,7 +290,7 @@ TEST(FindNodeAtPointTest, overlappingViewsWithParentPointerEventsBoxNone) { Element() .tag(2) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->zIndex = 1; auto &yogaStyle = sharedProps->yogaStyle; yogaStyle.setPositionType(yoga::PositionType::Absolute); @@ -326,7 +326,7 @@ TEST(FindNodeAtPointTest, overlappingViewsWithParentPointerEventsNone) { Element() .tag(1) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->pointerEvents = PointerEventsMode::None; return sharedProps; }) @@ -339,7 +339,7 @@ TEST(FindNodeAtPointTest, overlappingViewsWithParentPointerEventsNone) { Element() .tag(2) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->zIndex = 1; auto &yogaStyle = sharedProps->yogaStyle; yogaStyle.setPositionType(yoga::PositionType::Absolute); diff --git a/packages/react-native/ReactCommon/react/renderer/core/tests/LayoutableShadowNodeTest.cpp b/packages/react-native/ReactCommon/react/renderer/core/tests/LayoutableShadowNodeTest.cpp index 575221be7a3..c974595b4fd 100644 --- a/packages/react-native/ReactCommon/react/renderer/core/tests/LayoutableShadowNodeTest.cpp +++ b/packages/react-native/ReactCommon/react/renderer/core/tests/LayoutableShadowNodeTest.cpp @@ -291,7 +291,7 @@ TEST(LayoutableShadowNodeTest, relativeLayoutMetricsOnTransformedNode) { shadowNode.setLayoutMetrics(layoutMetrics); }) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->transform = Transform::Scale(0.5, 0.5, 1); return sharedProps; }) @@ -340,7 +340,7 @@ TEST(LayoutableShadowNodeTest, noOverflow) { }).children({ Element() .props([=] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; auto &yogaStyle = props.yogaStyle; yogaStyle.setDimension(yoga::Dimension::Width, yoga::StyleSizeLength::points(100)); @@ -351,7 +351,7 @@ TEST(LayoutableShadowNodeTest, noOverflow) { .children({ Element() .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; auto &yogaStyle = props.yogaStyle; yogaStyle.setPositionType(yoga::PositionType::Absolute); @@ -405,7 +405,7 @@ TEST(LayoutableShadowNodeTest, overflowInsetFrameToRightAndDown) { }).children({ Element() .props([=] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; auto &yogaStyle = props.yogaStyle; yogaStyle.setDimension(yoga::Dimension::Width, yoga::StyleSizeLength::points(100)); @@ -416,7 +416,7 @@ TEST(LayoutableShadowNodeTest, overflowInsetFrameToRightAndDown) { .children({ Element() .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; auto &yogaStyle = props.yogaStyle; yogaStyle.setPositionType(yoga::PositionType::Absolute); @@ -471,7 +471,7 @@ TEST(LayoutableShadowNodeTest, overflowInsetFrameToLeftAndTop) { }).children({ Element() .props([=] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; auto &yogaStyle = props.yogaStyle; yogaStyle.setDimension(yoga::Dimension::Width, yoga::StyleSizeLength::points(100)); @@ -482,7 +482,7 @@ TEST(LayoutableShadowNodeTest, overflowInsetFrameToLeftAndTop) { .children({ Element() .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; auto &yogaStyle = props.yogaStyle; yogaStyle.setPositionType(yoga::PositionType::Absolute); @@ -541,7 +541,7 @@ TEST(LayoutableShadowNodeTest, overflowInsetFrameToAllSides) { }).children({ Element() .props([=] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; auto &yogaStyle = props.yogaStyle; yogaStyle.setDimension(yoga::Dimension::Width, yoga::StyleSizeLength::points(100)); @@ -552,7 +552,7 @@ TEST(LayoutableShadowNodeTest, overflowInsetFrameToAllSides) { .children({ Element() .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; auto &yogaStyle = props.yogaStyle; yogaStyle.setPositionType(yoga::PositionType::Absolute); @@ -564,7 +564,7 @@ TEST(LayoutableShadowNodeTest, overflowInsetFrameToAllSides) { }), Element() .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; auto &yogaStyle = props.yogaStyle; yogaStyle.setPositionType(yoga::PositionType::Absolute); @@ -620,7 +620,7 @@ TEST(LayoutableShadowNodeTest, relativeLayoutMetricsOnTransformedParent) { .children({ Element() .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->transform = Transform::Scale(0.5, 0.5, 1); return sharedProps; }) @@ -755,7 +755,7 @@ TEST( .children({ Element() .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->transform = Transform::Scale(0.5, 0.5, 1); return sharedProps; }) @@ -840,7 +840,7 @@ TEST(LayoutableShadowNodeTest, relativeLayoutMetricsOnSameTransformedNode) { auto element = Element() .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->transform = Transform::Scale(2, 2, 1); return sharedProps; }) @@ -1017,7 +1017,7 @@ TEST(LayoutableShadowNodeTest, invertedVerticalView) { auto element = Element() .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->transform = Transform::VerticalInversion(); // Inverted return sharedProps; }) @@ -1093,7 +1093,7 @@ TEST(LayoutableShadowNodeTest, nestedInvertedVerticalView) { auto element = Element() .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->transform = Transform::VerticalInversion(); // Inverted return sharedProps; }) @@ -1179,7 +1179,7 @@ TEST(LayoutableShadowNodeTest, nestedDoubleInvertedVerticalView) { auto element = Element() .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->transform = Transform::VerticalInversion(); // Inverted return sharedProps; }) @@ -1195,7 +1195,7 @@ TEST(LayoutableShadowNodeTest, nestedDoubleInvertedVerticalView) { layoutMetrics.frame.size = {.width=100, .height=200}; shadowNode.setLayoutMetrics(layoutMetrics); }).props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->transform = Transform::VerticalInversion(); // Inverted return sharedProps; }).children({ @@ -1259,7 +1259,7 @@ TEST(LayoutableShadowNodeTest, invertedHorizontalView) { auto element = Element() .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->transform = Transform::HorizontalInversion(); // Inverted return sharedProps; }) @@ -1331,7 +1331,7 @@ TEST(LayoutableShadowNodeTest, nestedInvertedHorizontalView) { auto element = Element() .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); sharedProps->transform = Transform::HorizontalInversion(); // Inverted return sharedProps; }) diff --git a/packages/react-native/ReactCommon/react/renderer/element/tests/ElementTest.cpp b/packages/react-native/ReactCommon/react/renderer/element/tests/ElementTest.cpp index 3f577136a53..5dfde50211e 100644 --- a/packages/react-native/ReactCommon/react/renderer/element/tests/ElementTest.cpp +++ b/packages/react-native/ReactCommon/react/renderer/element/tests/ElementTest.cpp @@ -26,7 +26,7 @@ TEST(ElementTest, testNormalCases) { auto shadowNodeAB = std::shared_ptr{}; auto shadowNodeABA = std::shared_ptr{}; - auto propsAA = std::make_shared(); + auto propsAA = std::make_shared(); propsAA->nativeId = "node AA"; // clang-format off @@ -51,7 +51,7 @@ TEST(ElementTest, testNormalCases) { .reference(shadowNodeAB) .tag(3) .props([]() { - auto props = std::make_shared(); + auto props = std::make_shared(); props->nativeId = "node AB"; return props; }) @@ -60,7 +60,7 @@ TEST(ElementTest, testNormalCases) { .reference(shadowNodeABA) .tag(4) .props([]() { - auto props = std::make_shared(); + auto props = std::make_shared(); props->nativeId = "node ABA"; return props; }) diff --git a/packages/react-native/ReactCommon/react/renderer/mounting/tests/DifferentiatorUnflattenTest.cpp b/packages/react-native/ReactCommon/react/renderer/mounting/tests/DifferentiatorUnflattenTest.cpp index 6e886866e16..e0e65f3e98a 100644 --- a/packages/react-native/ReactCommon/react/renderer/mounting/tests/DifferentiatorUnflattenTest.cpp +++ b/packages/react-native/ReactCommon/react/renderer/mounting/tests/DifferentiatorUnflattenTest.cpp @@ -112,7 +112,7 @@ class DifferentiatorUnflattenTest : public ::testing::Test { rootShadowNode_ = std::static_pointer_cast(rootShadowNode_->cloneTree( node->getFamily(), [&](const ShadowNode& oldShadowNode) { - auto viewProps = std::make_shared(); + auto viewProps = std::make_shared(); callback(*viewProps); return oldShadowNode.clone( ShadowNodeFragment{.props = viewProps}); diff --git a/packages/react-native/ReactCommon/react/renderer/mounting/tests/OrderIndexTest.cpp b/packages/react-native/ReactCommon/react/renderer/mounting/tests/OrderIndexTest.cpp index 3196a12487e..fd37963f476 100644 --- a/packages/react-native/ReactCommon/react/renderer/mounting/tests/OrderIndexTest.cpp +++ b/packages/react-native/ReactCommon/react/renderer/mounting/tests/OrderIndexTest.cpp @@ -82,7 +82,7 @@ class OrderIndexTest : public ::testing::Test { rootShadowNode_ = std::static_pointer_cast(rootShadowNode_->cloneTree( node->getFamily(), [&](const ShadowNode& oldShadowNode) { - auto viewProps = std::make_shared(); + auto viewProps = std::make_shared(); callback(*viewProps); return oldShadowNode.clone( ShadowNodeFragment{.props = viewProps}); diff --git a/packages/react-native/ReactCommon/react/renderer/mounting/tests/ShadowTreeLifeCycleTest.cpp b/packages/react-native/ReactCommon/react/renderer/mounting/tests/ShadowTreeLifeCycleTest.cpp index 772814b0dfa..0b9f648f30c 100644 --- a/packages/react-native/ReactCommon/react/renderer/mounting/tests/ShadowTreeLifeCycleTest.cpp +++ b/packages/react-native/ReactCommon/react/renderer/mounting/tests/ShadowTreeLifeCycleTest.cpp @@ -445,7 +445,7 @@ TEST_F(ShadowTreeLifecycleTest, moveFirstChildToLast) { auto builder = simpleComponentBuilder(); auto makeProps = [](const std::string& id) { - auto props = std::make_shared(); + auto props = std::make_shared(); props->nativeId = id; return props; }; diff --git a/packages/react-native/ReactCommon/react/renderer/mounting/tests/StackingContextTest.cpp b/packages/react-native/ReactCommon/react/renderer/mounting/tests/StackingContextTest.cpp index 9d165105786..42421a23729 100644 --- a/packages/react-native/ReactCommon/react/renderer/mounting/tests/StackingContextTest.cpp +++ b/packages/react-native/ReactCommon/react/renderer/mounting/tests/StackingContextTest.cpp @@ -162,7 +162,7 @@ class StackingContextTest : public ::testing::Test { rootShadowNode_ = std::static_pointer_cast(rootShadowNode_->cloneTree( node->getFamily(), [&](const ShadowNode& oldShadowNode) { - auto viewProps = std::make_shared(); + auto viewProps = std::make_shared(); callback(*viewProps); return oldShadowNode.clone( ShadowNodeFragment{.props = viewProps}); diff --git a/packages/react-native/ReactCommon/react/renderer/uimanager/tests/FindShadowNodeByTagTest.cpp b/packages/react-native/ReactCommon/react/renderer/uimanager/tests/FindShadowNodeByTagTest.cpp index 46f4cfb5764..f2ac197f0c0 100644 --- a/packages/react-native/ReactCommon/react/renderer/uimanager/tests/FindShadowNodeByTagTest.cpp +++ b/packages/react-native/ReactCommon/react/renderer/uimanager/tests/FindShadowNodeByTagTest.cpp @@ -85,7 +85,7 @@ class FindShadowNodeByTagTest : public ::testing::Test { .tag(viewTag_) .surfaceId(surfaceId_) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto& yogaStyle = sharedProps->yogaStyle; yogaStyle.setDimension( yoga::Dimension::Width, diff --git a/packages/react-native/ReactCommon/react/renderer/uimanager/tests/PointerEventsProcessorTest.cpp b/packages/react-native/ReactCommon/react/renderer/uimanager/tests/PointerEventsProcessorTest.cpp index 79f90dc15b9..f868cf4d0f2 100644 --- a/packages/react-native/ReactCommon/react/renderer/uimanager/tests/PointerEventsProcessorTest.cpp +++ b/packages/react-native/ReactCommon/react/renderer/uimanager/tests/PointerEventsProcessorTest.cpp @@ -101,7 +101,7 @@ class PointerEventsProcessorTest : public ::testing::Test { .surfaceId(surfaceId_) .reference(nodeA_) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; listenToAllPointerEvents(props); auto &yogaStyle = props.yogaStyle; @@ -119,7 +119,7 @@ class PointerEventsProcessorTest : public ::testing::Test { .surfaceId(surfaceId_) .reference(nodeAA_) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; listenToAllPointerEvents(props); auto &yogaStyle = props.yogaStyle; @@ -133,7 +133,7 @@ class PointerEventsProcessorTest : public ::testing::Test { .surfaceId(surfaceId_) .reference(nodeB_) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; listenToAllPointerEvents(props); auto &yogaStyle = props.yogaStyle; @@ -151,7 +151,7 @@ class PointerEventsProcessorTest : public ::testing::Test { .surfaceId(surfaceId_) .reference(nodeBB_) .props([] { - auto sharedProps = std::make_shared(); + auto sharedProps = std::make_shared(); auto &props = *sharedProps; listenToAllPointerEvents(props); auto &yogaStyle = props.yogaStyle; diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api index 5a33e7d7d9d..a360d98fce0 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api @@ -732,6 +732,7 @@ using facebook::react::ValueFactory = std::function; using facebook::react::ViewProps = facebook::react::HostPlatformViewProps; +using facebook::react::ViewShadowNodeProps = facebook::react::ViewProps; using facebook::react::VirtualViewComponentDescriptor = facebook::react::ConcreteComponentDescriptor; using facebook::react::parsePlatformColorFn = facebook::react::SharedColor(*)(const facebook::react::ContextContainer&, int32_t, const facebook::react::RawValue&); template @@ -5413,16 +5414,11 @@ class facebook::react::ViewComponentDescriptor : public facebook::react::Concret public ViewComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters); } -class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { +class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { public ViewShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); public ViewShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits); } -class facebook::react::ViewShadowNodeProps : public facebook::react::HostPlatformViewProps { - public ViewShadowNodeProps() = default; - public ViewShadowNodeProps(const facebook::react::PropsParserContext& context, const facebook::react::ViewShadowNodeProps& sourceProps, const facebook::react::RawProps& rawProps); -} - class facebook::react::ViewTransitionModule : public facebook::react::UIManagerViewTransitionDelegate, public facebook::react::UIManagerCommitHook, public facebook::react::MountingOverrideDelegate { public virtual bool shouldOverridePullTransaction() const override; public virtual facebook::react::RootShadowNode::Unshared shadowTreeWillCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& oldRootShadowNode, const facebook::react::RootShadowNode::Unshared& newRootShadowNode, const facebook::react::ShadowTreeCommitOptions& commitOptions) noexcept override; diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api index a10464aed19..e521b074ce8 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api @@ -731,6 +731,7 @@ using facebook::react::ValueFactory = std::function; using facebook::react::ViewProps = facebook::react::HostPlatformViewProps; +using facebook::react::ViewShadowNodeProps = facebook::react::ViewProps; using facebook::react::VirtualViewComponentDescriptor = facebook::react::ConcreteComponentDescriptor; using facebook::react::parsePlatformColorFn = facebook::react::SharedColor(*)(const facebook::react::ContextContainer&, int32_t, const facebook::react::RawValue&); template @@ -5227,16 +5228,11 @@ class facebook::react::ViewComponentDescriptor : public facebook::react::Concret public ViewComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters); } -class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { +class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { public ViewShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); public ViewShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits); } -class facebook::react::ViewShadowNodeProps : public facebook::react::HostPlatformViewProps { - public ViewShadowNodeProps() = default; - public ViewShadowNodeProps(const facebook::react::PropsParserContext& context, const facebook::react::ViewShadowNodeProps& sourceProps, const facebook::react::RawProps& rawProps); -} - class facebook::react::ViewTransitionModule : public facebook::react::UIManagerViewTransitionDelegate, public facebook::react::UIManagerCommitHook, public facebook::react::MountingOverrideDelegate { public virtual bool shouldOverridePullTransaction() const override; public virtual facebook::react::RootShadowNode::Unshared shadowTreeWillCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& oldRootShadowNode, const facebook::react::RootShadowNode::Unshared& newRootShadowNode, const facebook::react::ShadowTreeCommitOptions& commitOptions) noexcept override; diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api index b357d56bfc8..fc6a7f8949e 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api @@ -732,6 +732,7 @@ using facebook::react::ValueFactory = std::function; using facebook::react::ViewProps = facebook::react::HostPlatformViewProps; +using facebook::react::ViewShadowNodeProps = facebook::react::ViewProps; using facebook::react::VirtualViewComponentDescriptor = facebook::react::ConcreteComponentDescriptor; using facebook::react::parsePlatformColorFn = facebook::react::SharedColor(*)(const facebook::react::ContextContainer&, int32_t, const facebook::react::RawValue&); template @@ -5404,16 +5405,11 @@ class facebook::react::ViewComponentDescriptor : public facebook::react::Concret public ViewComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters); } -class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { +class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { public ViewShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); public ViewShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits); } -class facebook::react::ViewShadowNodeProps : public facebook::react::HostPlatformViewProps { - public ViewShadowNodeProps() = default; - public ViewShadowNodeProps(const facebook::react::PropsParserContext& context, const facebook::react::ViewShadowNodeProps& sourceProps, const facebook::react::RawProps& rawProps); -} - class facebook::react::ViewTransitionModule : public facebook::react::UIManagerViewTransitionDelegate, public facebook::react::UIManagerCommitHook, public facebook::react::MountingOverrideDelegate { public virtual bool shouldOverridePullTransaction() const override; public virtual facebook::react::RootShadowNode::Unshared shadowTreeWillCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& oldRootShadowNode, const facebook::react::RootShadowNode::Unshared& newRootShadowNode, const facebook::react::ShadowTreeCommitOptions& commitOptions) noexcept override; diff --git a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api index 4dd76e3aa93..5db822c2e8b 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api @@ -3596,6 +3596,7 @@ using facebook::react::ValueFactory = std::function; using facebook::react::ViewProps = facebook::react::HostPlatformViewProps; +using facebook::react::ViewShadowNodeProps = facebook::react::ViewProps; using facebook::react::VirtualViewComponentDescriptor = facebook::react::ConcreteComponentDescriptor; using facebook::react::parsePlatformColorFn = facebook::react::SharedColor(*)(const facebook::react::ContextContainer&, int32_t, const facebook::react::RawValue&); template @@ -7589,16 +7590,11 @@ class facebook::react::ViewComponentDescriptor : public facebook::react::Concret public ViewComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters); } -class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { +class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { public ViewShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); public ViewShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits); } -class facebook::react::ViewShadowNodeProps : public facebook::react::HostPlatformViewProps { - public ViewShadowNodeProps() = default; - public ViewShadowNodeProps(const facebook::react::PropsParserContext& context, const facebook::react::ViewShadowNodeProps& sourceProps, const facebook::react::RawProps& rawProps); -} - class facebook::react::ViewTransitionModule : public facebook::react::UIManagerViewTransitionDelegate, public facebook::react::UIManagerCommitHook, public facebook::react::MountingOverrideDelegate { public virtual bool shouldOverridePullTransaction() const override; public virtual facebook::react::RootShadowNode::Unshared shadowTreeWillCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& oldRootShadowNode, const facebook::react::RootShadowNode::Unshared& newRootShadowNode, const facebook::react::ShadowTreeCommitOptions& commitOptions) noexcept override; diff --git a/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api index 16e2dc5a0c8..f17f0b02df5 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api @@ -3583,6 +3583,7 @@ using facebook::react::ValueFactory = std::function; using facebook::react::ViewProps = facebook::react::HostPlatformViewProps; +using facebook::react::ViewShadowNodeProps = facebook::react::ViewProps; using facebook::react::VirtualViewComponentDescriptor = facebook::react::ConcreteComponentDescriptor; using facebook::react::parsePlatformColorFn = facebook::react::SharedColor(*)(const facebook::react::ContextContainer&, int32_t, const facebook::react::RawValue&); template @@ -7431,16 +7432,11 @@ class facebook::react::ViewComponentDescriptor : public facebook::react::Concret public ViewComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters); } -class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { +class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { public ViewShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); public ViewShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits); } -class facebook::react::ViewShadowNodeProps : public facebook::react::HostPlatformViewProps { - public ViewShadowNodeProps() = default; - public ViewShadowNodeProps(const facebook::react::PropsParserContext& context, const facebook::react::ViewShadowNodeProps& sourceProps, const facebook::react::RawProps& rawProps); -} - class facebook::react::ViewTransitionModule : public facebook::react::UIManagerViewTransitionDelegate, public facebook::react::UIManagerCommitHook, public facebook::react::MountingOverrideDelegate { public virtual bool shouldOverridePullTransaction() const override; public virtual facebook::react::RootShadowNode::Unshared shadowTreeWillCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& oldRootShadowNode, const facebook::react::RootShadowNode::Unshared& newRootShadowNode, const facebook::react::ShadowTreeCommitOptions& commitOptions) noexcept override; diff --git a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api index 48d9cc57fdb..6efb6780786 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api @@ -3596,6 +3596,7 @@ using facebook::react::ValueFactory = std::function; using facebook::react::ViewProps = facebook::react::HostPlatformViewProps; +using facebook::react::ViewShadowNodeProps = facebook::react::ViewProps; using facebook::react::VirtualViewComponentDescriptor = facebook::react::ConcreteComponentDescriptor; using facebook::react::parsePlatformColorFn = facebook::react::SharedColor(*)(const facebook::react::ContextContainer&, int32_t, const facebook::react::RawValue&); template @@ -7580,16 +7581,11 @@ class facebook::react::ViewComponentDescriptor : public facebook::react::Concret public ViewComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters); } -class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { +class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { public ViewShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); public ViewShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits); } -class facebook::react::ViewShadowNodeProps : public facebook::react::HostPlatformViewProps { - public ViewShadowNodeProps() = default; - public ViewShadowNodeProps(const facebook::react::PropsParserContext& context, const facebook::react::ViewShadowNodeProps& sourceProps, const facebook::react::RawProps& rawProps); -} - class facebook::react::ViewTransitionModule : public facebook::react::UIManagerViewTransitionDelegate, public facebook::react::UIManagerCommitHook, public facebook::react::MountingOverrideDelegate { public virtual bool shouldOverridePullTransaction() const override; public virtual facebook::react::RootShadowNode::Unshared shadowTreeWillCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& oldRootShadowNode, const facebook::react::RootShadowNode::Unshared& newRootShadowNode, const facebook::react::ShadowTreeCommitOptions& commitOptions) noexcept override; diff --git a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api index e40ffd1a577..7edcb2738ef 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api @@ -349,6 +349,7 @@ using facebook::react::ValueFactory = std::function; using facebook::react::ViewProps = facebook::react::HostPlatformViewProps; +using facebook::react::ViewShadowNodeProps = facebook::react::ViewProps; using facebook::react::VirtualViewComponentDescriptor = facebook::react::ConcreteComponentDescriptor; using facebook::react::parsePlatformColorFn = facebook::react::SharedColor(*)(const facebook::react::ContextContainer&, int32_t, const facebook::react::RawValue&); template @@ -3853,16 +3854,11 @@ class facebook::react::ViewComponentDescriptor : public facebook::react::Concret public ViewComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters); } -class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { +class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { public ViewShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); public ViewShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits); } -class facebook::react::ViewShadowNodeProps : public facebook::react::HostPlatformViewProps { - public ViewShadowNodeProps() = default; - public ViewShadowNodeProps(const facebook::react::PropsParserContext& context, const facebook::react::ViewShadowNodeProps& sourceProps, const facebook::react::RawProps& rawProps); -} - class facebook::react::ViewTransitionModule : public facebook::react::UIManagerViewTransitionDelegate, public facebook::react::UIManagerCommitHook, public facebook::react::MountingOverrideDelegate { public virtual bool shouldOverridePullTransaction() const override; public virtual facebook::react::RootShadowNode::Unshared shadowTreeWillCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& oldRootShadowNode, const facebook::react::RootShadowNode::Unshared& newRootShadowNode, const facebook::react::ShadowTreeCommitOptions& commitOptions) noexcept override; diff --git a/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api index 2c5d2474a71..d7f3c4120d6 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api @@ -348,6 +348,7 @@ using facebook::react::ValueFactory = std::function; using facebook::react::ViewProps = facebook::react::HostPlatformViewProps; +using facebook::react::ViewShadowNodeProps = facebook::react::ViewProps; using facebook::react::VirtualViewComponentDescriptor = facebook::react::ConcreteComponentDescriptor; using facebook::react::parsePlatformColorFn = facebook::react::SharedColor(*)(const facebook::react::ContextContainer&, int32_t, const facebook::react::RawValue&); template @@ -3707,16 +3708,11 @@ class facebook::react::ViewComponentDescriptor : public facebook::react::Concret public ViewComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters); } -class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { +class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { public ViewShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); public ViewShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits); } -class facebook::react::ViewShadowNodeProps : public facebook::react::HostPlatformViewProps { - public ViewShadowNodeProps() = default; - public ViewShadowNodeProps(const facebook::react::PropsParserContext& context, const facebook::react::ViewShadowNodeProps& sourceProps, const facebook::react::RawProps& rawProps); -} - class facebook::react::ViewTransitionModule : public facebook::react::UIManagerViewTransitionDelegate, public facebook::react::UIManagerCommitHook, public facebook::react::MountingOverrideDelegate { public virtual bool shouldOverridePullTransaction() const override; public virtual facebook::react::RootShadowNode::Unshared shadowTreeWillCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& oldRootShadowNode, const facebook::react::RootShadowNode::Unshared& newRootShadowNode, const facebook::react::ShadowTreeCommitOptions& commitOptions) noexcept override; diff --git a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api index 8c562f2e732..5537fec6eef 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api @@ -349,6 +349,7 @@ using facebook::react::ValueFactory = std::function; using facebook::react::ViewProps = facebook::react::HostPlatformViewProps; +using facebook::react::ViewShadowNodeProps = facebook::react::ViewProps; using facebook::react::VirtualViewComponentDescriptor = facebook::react::ConcreteComponentDescriptor; using facebook::react::parsePlatformColorFn = facebook::react::SharedColor(*)(const facebook::react::ContextContainer&, int32_t, const facebook::react::RawValue&); template @@ -3844,16 +3845,11 @@ class facebook::react::ViewComponentDescriptor : public facebook::react::Concret public ViewComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters); } -class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { +class facebook::react::ViewShadowNode : public facebook::react::ConcreteViewShadowNode { public ViewShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); public ViewShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits); } -class facebook::react::ViewShadowNodeProps : public facebook::react::HostPlatformViewProps { - public ViewShadowNodeProps() = default; - public ViewShadowNodeProps(const facebook::react::PropsParserContext& context, const facebook::react::ViewShadowNodeProps& sourceProps, const facebook::react::RawProps& rawProps); -} - class facebook::react::ViewTransitionModule : public facebook::react::UIManagerViewTransitionDelegate, public facebook::react::UIManagerCommitHook, public facebook::react::MountingOverrideDelegate { public virtual bool shouldOverridePullTransaction() const override; public virtual facebook::react::RootShadowNode::Unshared shadowTreeWillCommit(const facebook::react::ShadowTree& shadowTree, const facebook::react::RootShadowNode::Shared& oldRootShadowNode, const facebook::react::RootShadowNode::Unshared& newRootShadowNode, const facebook::react::ShadowTreeCommitOptions& commitOptions) noexcept override;