Fix configuration and encoding bugs in helper scripts#3398
Open
aoright wants to merge 1 commit into
Open
Conversation
This resolves two bugs under script/ directory: 1. Refactored static API URL generation in github_bot.py to be dynamic, enabling user-configured accounts to be queried properly. 2. Added explicit UTF-8 encoding (via io.open) for reading and writing files in make_content.py to prevent encoding crashes on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves two bugs under the script/ directory: 1. Refactored static API URL generation in github_bot.py to be dynamic, enabling user-configured accounts to be queried properly. 2. Added explicit UTF-8 encoding (via io.open) for reading and writing files in make_content.py to prevent encoding crashes on Windows.