Skip to content

Fix Tinybird benchmark runner auth#952

Open
fallintoplace wants to merge 2 commits into
ClickHouse:mainfrom
fallintoplace:fix-tinybird-runner-auth
Open

Fix Tinybird benchmark runner auth#952
fallintoplace wants to merge 2 commits into
ClickHouse:mainfrom
fallintoplace:fix-tinybird-runner-auth

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

What changed

  • Replaced the placeholder auth header with a required TINYBIRD_TOKEN environment variable.
  • Switched Tinybird requests to Authorization: Bearer ... and made curl fail on HTTP errors.
  • Made the runner fail fast on shell errors and invalid/non-numeric statistics.elapsed values.
  • Documented the required token in the Tinybird README.

Why

AUTH_HEADER=<TOKEN> is parsed by the shell as redirection syntax, so tinybird/run.sh fails before it can run any benchmark query.

Validation

  • bash -n tinybird/run.sh
  • env -u TINYBIRD_TOKEN ./tinybird/run.sh
  • mocked successful Tinybird responses and checked the output is a 43-entry JSON array with three numeric timings per query
  • mocked a non-numeric statistics.elapsed response and confirmed the runner exits non-zero

Comment thread tinybird/README.md Outdated
# Querying the data

Once the data is inserted you can create the endpoints needed to run the benchmark using pipes. `run.sh` will iterate through each endpoint.
Set `TINYBIRD_TOKEN` to a Tinybird token with read access before running the script.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a Tinybird account but the UI is rather complex and this README covers it only rudimentary.

@fallintoplace Since you seem familiar with Tinybird, maybe I could ask you to add

  • the steps to install the Tinybird CLI in section "Creating an account" above,
  • the steps to create and retrieve a "Tinybird Token" (l. 35),
  • the steps to run the INSERT (l. 24),
  • the exact invocation of run.sh (the PR message has an example)

@rschu1ze rschu1ze self-assigned this Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants