Add inline suggestion (ghost text) rendering primitive#125
Open
anxkhn wants to merge 1 commit into
Open
Conversation
Add an overlay-based inline suggestion primitive that draws dimmed ghost text anchored at the caret without mutating textStorage or shifting real text layout. This is the foundation for inline completions such as GitHub Copilot. - InlineSuggestion: Equatable model holding an offset and text. - InlineSuggestionView: sibling NSView overlay that typesets and draws CTLines using the same Core Text context setup as LineFragmentRenderer. - InlineSuggestionManager: builds CTLines from typing attributes, anchors the overlay at rectForOffset(offset), and repositions on layout. - TextView gains an inlineSuggestionManager and forwarding helpers, with updateLayout hooks in draw(_:) and layout().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a low-level rendering primitive for inline "ghost text" suggestions: text drawn after the caret that previews content the user has not typed yet (the GitHub Copilot / predictive-completion UI pattern).
New public API:
InlineSuggestion: a value type holding a documentoffsetand thetextto show (may be multi-line).TextView.setInlineSuggestion(_:at:): show a suggestion anchored at a given offset.TextView.setInlineSuggestion(_:): show a suggestion anchored at the primary caret.TextView.clearInlineSuggestion(): clear it.Implementation notes:
textStorageor shifts real text layout, so it cannot pollute undo, selection, or the document.InlineSuggestionManagerowns the overlay view and positions it from the text view's existing layout/caret geometry;InlineSuggestionViewdraws the (optionally multi-line) text.nilor an empty string clears any existing suggestion.This is the rendering layer of a planned native inline-completion feature for the CodeEdit stack (this package renders,
CodeEditSourceEditorcoordinates request/accept/dismiss,CodeEditwires up the provider). This PR is self-contained and only touchesCodeEditTextView.Related Issues
Checklist
Screenshots
This layer is a non-visual API primitive: it adds no user-facing UI on its own, and the visible ghost text only appears once a higher layer drives it. The rendered result will be shown in the downstream
CodeEditSourceEditor/CodeEditPRs. Behavior here is covered by unit tests, including a test that the suggestion never mutatestextStorage.Testing
xcodebuild -scheme CodeEditTextView -destination "platform=macOS,name=My Mac" clean test: all 72 tests pass, including the newInlineSuggestionTestssuite.