fix(core): pin supervisor image tag to gateway version for all drivers#2070
Open
benoitf wants to merge 1 commit into
Open
fix(core): pin supervisor image tag to gateway version for all drivers#2070benoitf wants to merge 1 commit into
benoitf wants to merge 1 commit into
Conversation
benoitf
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
Collaborator
|
/ok to test cb62ca9 |
|
Label |
TaylorMutch
reviewed
Jun 30, 2026
| pub const DEFAULT_SERVICE_ROUTING_DOMAIN: &str = "openshell.localhost"; | ||
|
|
||
| /// Default OCI image for the openshell-sandbox supervisor binary. | ||
| #[deprecated(note = "Use `default_supervisor_image()` which pins the tag to the gateway version")] |
Collaborator
There was a problem hiding this comment.
Do we need a deprecation notice? We're still alpha - If we do this all in one PR, what would be needed to accomplish that and remove this deprecated value?
Contributor
Author
There was a problem hiding this comment.
@TaylorMutch removed the notice (and the variable)
I also updated the documentation part
benoitf
force-pushed
the
2068-pin-supervisor-image/fb
branch
2 times, most recently
from
e3723ae to
0582804
Compare
The Podman and Kubernetes drivers defaulted the supervisor image to `:latest` via DEFAULT_SUPERVISOR_IMAGE, while the Docker driver already resolved a version-pinned tag. Extract the tag resolution logic into openshell-core so all three drivers use the same OPENSHELL_IMAGE_TAG > IMAGE_TAG > CARGO_PKG_VERSION priority chain. Closes NVIDIA#2068 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
force-pushed
the
2068-pin-supervisor-image/fb
branch
from
0582804 to
aa8af37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the Docker driver's compile-time supervisor image tag resolution into
openshell-coreso all three compute drivers (Docker, Podman, Kubernetes) pin the supervisor image to the gateway version instead of defaulting to:latest.Related Issue
Closes #2068
Changes
resolve_supervisor_image_tag()anddefault_supervisor_image()toopenshell-core::configwith the same priority chain the Docker driver already used:OPENSHELL_IMAGE_TAG>IMAGE_TAG>CARGO_PKG_VERSION(falls back todevfor0.0.0)DEFAULT_SUPERVISOR_IMAGE_REPOconstant (repo without tag) toopenshell-coreDEFAULT_SUPERVISOR_IMAGE(the:latestconstant)default_supervisor_image()in config default and make the CLI--supervisor-imagearg optional with version-pinned fallbackdefault_supervisor_image()in config default and CLI fallback:latestto use the dynamic defaultTesting
mise run pre-commitpassesChecklist