refactor(api): remove SandboxTemplate.volume_claim_templates#2088
Open
elezar wants to merge 1 commit into
Open
refactor(api): remove SandboxTemplate.volume_claim_templates#2088elezar wants to merge 1 commit into
elezar wants to merge 1 commit into
Conversation
The field was added during the Kubernetes driver extraction refactor (#817) as a pass-through mechanism, but was never wired up to a CLI flag, Python SDK helper, or any documentation. The only reachable user path was raw gRPC construction. The Kubernetes driver now always injects the default workspace PVC, removing the branching logic that checked for a user-supplied VCT. Field number 9 is reserved in the proto to prevent reuse. Signed-off-by: Evan Lezar <elezar@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
elezar
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
SandboxTemplate.volume_claim_templatesfrom the public API. The field was added during the Kubernetes driver extraction refactor (#817) but was never surfaced to users — no CLI flag, no Python SDK helper, no documentation. The only way to reach it was raw gRPC construction.The Kubernetes driver now unconditionally injects the default workspace PVC, removing the branching logic that existed to accommodate user-supplied VCTs. Field number 9 is reserved in the proto to prevent future reuse.
See also #2034 (feat(kubernetes): support PVC subPath driver config), which covers the supported path for PVC customisation via driver config.
Related Issue
N/A
Changes
proto/openshell.proto: removed field 9, addedreserved 9/reserved "volume_claim_templates"crates/openshell-server/src/grpc/validation.rs: removed size-limit validation for the fieldcrates/openshell-server/src/compute/mod.rs: removed pass-through inbuild_platform_config()crates/openshell-driver-kubernetes/src/driver.rs: removeduser_has_vct/inject_workspacebranching; default workspace VCT is now always injectedTesting
mise run pre-commitpassesmainunrelated to this change)Checklist