ci: Allow flags board workflow to inherit secrets#717
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "ci: allow flags board workflow secrets i..." | Re-trigger Greptile |
Contributor
posthog-python Compliance ReportDate: 2026-07-01 09:24:07 UTC ✅ All Tests Passed!45/45 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 16/16 tests passed View Details
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The feature flags project-board caller sometimes failed CI around Semgrep's broad
secrets: inheritfinding. Replacing it with explicit secret mapping caused GitHub to reject the reusable workflow at startup because the central.githubworkflow does not declareworkflow_call.secrets.This keeps the required inheritance for that reusable workflow and documents the Semgrep exception inline.
💚 How did you test it?
.github/workflows/call-flags-project-board.ymlwith PyYAML and verifiedsecretsresolves toinherit.git diff --check.secrets: inheritand verified# nosemgrepsuppresses the intentional exception..githubSemgrep rules locally against the workflow file.📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Pi investigated the failing workflow behavior, confirmed explicit secret mapping is incompatible with the pinned central reusable workflow, and kept
secrets: inheritas the required GitHub Actions configuration while adding a scoped Semgrep suppression with context for reviewers.