Skip to content

4.x: Streamable + range, fromArray, take, error, defer#8206

Merged
akarnokd merged 7 commits into
ReactiveX:4.xfrom
akarnokd:4xStreamableTake
Jul 1, 2026
Merged

4.x: Streamable + range, fromArray, take, error, defer#8206
akarnokd merged 7 commits into
ReactiveX:4.xfrom
akarnokd:4xStreamableTake

Conversation

@akarnokd

Copy link
Copy Markdown
Member

Also

  • Fix missing onAssembly calls
  • Update RxJavaPlugins to support Streamable onAssembly calls
  • Inlined a few TestHelper.withXXX into RxJavaTest.
  • Added missing extends RxJavaTests.
  • Introduce ThrowableWrapper as a special class indicating it holds some exception that needs to be propagated.
  • Make sure Streamable unwraps the ThrowableWrappers the right time

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.601 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/main/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorService.java: 4.453
src/test/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorServiceTest.java: 4.749

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.50%. Comparing base (e8ec405) to head (8a53562).

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8206      +/-   ##
============================================
+ Coverage     98.44%   98.50%   +0.06%     
- Complexity     6808     6854      +46     
============================================
  Files           777      782       +5     
  Lines         48556    48661     +105     
  Branches       6569     6579      +10     
============================================
+ Hits          47799    47933     +134     
+ Misses          561      534      -27     
+ Partials        196      194       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hiSandog

hiSandog commented Jul 1, 2026

Copy link
Copy Markdown

The ThrowableWrapper part is the one I would want especially well covered. It would be useful to have tests showing Streamable.error, defer, and plugin onAssembly paths unwrap exactly once and do not double-wrap fatal exceptions. That keeps the new API promotion from subtly changing error identity or plugin hooks compared with the existing reactive types.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.601 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/main/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorService.java: 4.453
src/test/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorServiceTest.java: 4.749

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@akarnokd

akarnokd commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

The ThrowableWrapper part is the one I would want especially well covered. It would be useful to have tests showing Streamable.error, defer, and plugin onAssembly paths unwrap exactly once and do not double-wrap fatal exceptions. That keeps the new API promotion from subtly changing error identity or plugin hooks compared with the existing reactive types.

How are you using RxJava?

Are you a drive-by commenter without stakes or did you ask an AI to write a comment?

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.601 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/main/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorService.java: 4.453
src/test/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorServiceTest.java: 4.749

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.601 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/main/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorService.java: 4.453
src/test/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorServiceTest.java: 4.749

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.601 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/main/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorService.java: 4.453
src/test/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorServiceTest.java: 4.749

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.601 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/main/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorService.java: 4.453
src/test/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorServiceTest.java: 4.749

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.601 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/main/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorService.java: 4.453
src/test/java/io/reactivex/rxjava4/internal/schedulers/SchedulerToExecutorServiceTest.java: 4.749

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@akarnokd akarnokd merged commit 93d6ddd into ReactiveX:4.x Jul 1, 2026
6 checks passed
@akarnokd akarnokd deleted the 4xStreamableTake branch July 1, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants