Skip to content

revert pr #11957 (3b0f778)#11959

Open
jNullj wants to merge 1 commit into
badges:masterfrom
jNullj:fix/revert-11957
Open

revert pr #11957 (3b0f778)#11959
jNullj wants to merge 1 commit into
badges:masterfrom
jNullj:fix/revert-11957

Conversation

@jNullj

@jNullj jNullj commented Jun 30, 2026

Copy link
Copy Markdown
Member

reverts 3b0f778 made by pr #11957
due to fix of nodejs/node#63989

@github-actions

Copy link
Copy Markdown
Contributor
Messages
📖 ✨ Thanks for your contribution to Shields, @jNullj!

Generated by 🚫 dangerJS against 24a14e3

@jNullj jNullj added the developer-experience Dev tooling, test framework, and CI label Jun 30, 2026
@jNullj

jNullj commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

First PR from my new home 😄

@jNullj jNullj marked this pull request as ready for review June 30, 2026 11:00
@PyvesB

PyvesB commented Jun 30, 2026

Copy link
Copy Markdown
Member

I don't think we should merge this straight away, it's not because the fix was released that it is included in the Node.js versions pulled in by GitHub actions. The issue was still happening a couple of days ago in our GitHub actions environment.

@LitoMore

Copy link
Copy Markdown
Member

Ah, I didn't notice the PR comment. Let's wait for the upstream fixes, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer-experience Dev tooling, test framework, and CI

Development

Successfully merging this pull request may close these issues.

3 participants