LITE-33583: Refresh OpenAPI spec fixture to v37.0#87
Open
pcaro wants to merge 1 commit into
Open
Conversation
The bundled OpenAPI spec fixture (tests/data/specs.yml) was a v22.0 snapshot from 2021. Replace it with the current live spec (v37.0) from https://apispec.connect.cloudblue.com/connect-openapi30.yml so the introspection tests validate against the API's real, current structure. Update the exact-match assertions in test_openapi.py whose expected values changed with the new spec: get_namespaces (11 -> 21), get_collections (18 -> 29), get_actions and get_nested_collections for products. No client code changes: the client is spec-agnostic and only loads the spec for optional help/validation.
pcaro
requested review from
arnaugiralt,
jonatrios,
nerimartinez,
qarlosh and
sergiopalacio
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the bundled OpenAPI spec test fixture (
tests/data/specs.yml) — a v22.0 snapshot from 2021 — with the current live spec v37.0 from https://apispec.connect.cloudblue.com/connect-openapi30.yml, and update the affected introspection assertions intests/client/test_openapi.py.Why
The fixture drove the
OpenAPISpecsintrospection tests against a 4-year-old API structure. Refreshing it makes those tests validate against the API's real, current shape. No client code changes: the client is spec-agnostic (generic fluent interface) and only loads the spec for optional help/validation.Assertion changes
get_namespaces: 11 → 21 (new: billing, catalog, custom, devops, embed, leads, localization, modules, offers-ns, pim, statistics)get_collections: 18 → 29 (acl, brand(s), conversations, domains, folders, idps, metrics, news, portal, sla, sli, …)get_actions('products/PRD-000'): now includes the taxonomies sub-paths (existing parser behavior, just more data in the spec)get_nested_collections('products/PRD-000'):agreementsdropped;guidelines,item-groups,messages,taxonomiesaddedVerification
uv run pytest→ 407 passed.🤖 Generated with Claude Code