fix: satisfy PHPStan 2.2.3#10364
Open
memleakd wants to merge 2 commits into
Open
Conversation
- Remove redundant output-buffer level checks after ob_start() - Narrow output-buffer helper return types Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
michalsn
reviewed
Jul 1, 2026
michalsn
left a comment
Member
There was a problem hiding this comment.
While these changes make sense for the test files, I don't think command() should be treated the same way. It executes arbitrary command code that may alter the output buffer state, so we cannot assume the buffer remains active.
Signed-off-by: memleakd <121398829+memleakd@users.noreply.github.com>
Contributor
Author
Good point, thanks. Updated it to handle that case explicitly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes PHPStan failures after
phpstan/phpstanstarted resolving to2.2.3.PHPStan now narrows
ob_get_contents()/ob_get_clean()/ob_get_flush()/ob_get_length()to non-falsewhile output buffering is active: phpstan/phpstan-src#5909Because of that, a few existing output-buffering tests now report redundant
ob_get_level() > 0checks, and helper return types can be narrowed fromfalse|stringtostring.There is no behavior change.
Checklist: