chore(opentelemetry): Add worker as export | sort exports#21859
Open
JPeer264 wants to merge 1 commit into
Open
chore(opentelemetry): Add worker as export | sort exports#21859JPeer264 wants to merge 1 commit into
JPeer264 wants to merge 1 commit into
Conversation
JPeer264
requested review from
andreiborza and
mydea
and removed request for
a team
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+24
to
+34
| "node": { | ||
| "import": "./build/esm/index.js", | ||
| "require": "./build/cjs/index.js" | ||
| }, | ||
| "require": { | ||
| "node": { | ||
| "types": "./build/types/index.d.ts", | ||
| "default": "./build/cjs/index.js" | ||
| }, | ||
| "browser": { | ||
| "types": "./build/types/index.d.ts", | ||
| "default": "./build/cjs/index.browser.js" | ||
| }, | ||
| "types": "./build/types/index.d.ts", | ||
| "default": "./build/cjs/index.js" | ||
| "worker": { | ||
| "import": "./build/esm/index.js", | ||
| "require": "./build/cjs/index.js" | ||
| }, | ||
| "browser": { | ||
| "import": "./build/esm/index.browser.js", | ||
| "require": "./build/cjs/index.browser.js" |
Contributor
There was a problem hiding this comment.
Bug: The exports order in package.json is incorrect. Generic import/require conditions appear before the browser condition, causing bundlers to select the Node.js build for browser environments.
Severity: HIGH
Suggested Fix
Reorder the exports conditions in package.json to place specific environment conditions (browser, worker, node) before the generic import and require fallbacks. This ensures that environment-specific bundlers select the correct entry point. For example, the browser condition should be evaluated before the top-level import condition.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/opentelemetry/package.json#L21-L34
Potential issue: The `exports` map in `package.json` has an incorrect condition order.
Generic conditions `import` and `require` are listed before specific environment
conditions like `browser`. According to Node.js resolution rules, the first matching
condition is used. This means browser bundlers will match the generic `import` condition
and receive the Node.js-specific build (`./build/esm/index.js`). This build imports
`node:async_hooks`, which is not available in browsers, leading to runtime errors. The
intended browser-specific build, which provides a safe stub for Node.js APIs, will be
ignored.
Did we get this right? 👍 / 👎 to inform future reviews.
mydea
reviewed
Jun 30, 2026
Comment on lines
+22
to
+23
| "import": "./build/esm/index.js", | ||
| "require": "./build/cjs/index.js", |
Member
There was a problem hiding this comment.
would this not lead to these being picked over the node/browser/worker ones? 🤔 should these not be below those to be picked as fallbacks...?
Member
There was a problem hiding this comment.
basically what the clanker found below :D
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the future we need to import from
@sentry/opentelemetry. As there is now abrowserexport we go into that path, based on the wrangler's build preferences. As of now, the browser entrypoint is only here to print a warning - which would also happen on Cloudflare.In order to use the correct entrypoint in Cloudflare the
workerentry has been added.On top I also sorted the exports to match the other
package.jsons. Instead ofimport -> node -> defaultit is nownode -> import(so it is one depth less)