fix(extensions): set-priority repairs corrupted boolean priority#3268
Open
jawwad-ali wants to merge 1 commit into
Open
fix(extensions): set-priority repairs corrupted boolean priority#3268jawwad-ali wants to merge 1 commit into
jawwad-ali wants to merge 1 commit into
Conversation
The set-priority skip guard 'isinstance(raw_priority, int) and raw_priority == priority' treats a stored boolean as a match because isinstance(True, int) is True and True == 1 (False == 0). So a corrupted boolean priority short-circuits to 'already has priority N' and is never rewritten to a real int — contradicting the adjacent comment that promises corrupted values get repaired. Exclude bools explicitly, mirroring normalize_priority's own bool guard. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
extension set-prioritycommand has a skip-if-unchanged guard whose comment promises that corrupted values get repaired:But in Python
isinstance(True, int)isTrueandTrue == 1(False == 0). So a corrupted boolean priority (e.g.True) matches the guard when the user runsset-priority <ext> 1: the command reports "already has priority 1" and exits without rewriting the bool to a real int — the exact opposite of what the comment promises.normalize_priority()already guards this (if isinstance(value, bool): return default); this call site didn't.Fix
Exclude bools from the skip guard, mirroring
normalize_priority:Now a corrupted bool falls through and is repaired to a real int.
Testing
test_set_priority_repairs_corrupted_bool: installs an extension, injectspriority: True, runsset-priority test-ext 1, asserts it reports priority changed (not already has priority) and the reloaded value is1withnot isinstance(..., bool). Fails before (reports "already has priority 1", verified by source-stash), passes after.TestExtensionPriorityCLIpasses (8 tests);uvx ruff checkclean. The existing same-value test (priority 5, a real int) stays green.AI Disclosure
Found and fixed with Claude Code (Claude Opus 4.8) under my direction. AI flagged the bool-is-int trap against the comment's promise; I confirmed the short-circuit, proved fail-before via source-stash, and reviewed the diff before submitting.