Bump js-yaml from 4.2.0 to 5.0.0 in /extensions/ql-vscode#4438
Open
dependabot[bot] wants to merge 3 commits into
Open
Bump js-yaml from 4.2.0 to 5.0.0 in /extensions/ql-vscode#4438dependabot[bot] wants to merge 3 commits into
dependabot[bot] wants to merge 3 commits into
Conversation
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.2.0 to 5.0.0. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.2.0...5.0.0) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 5.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
Author
|
A newer version of js-yaml exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
…tem on Windows The `handleRemoveHistoryItem` method called `getCurrent()` after several async operations. On Windows, VS Code fires `onDidChangeSelection` asynchronously during awaits (after `refresh()` from `remove()`), which could change the current item to an unexpected value before `getCurrent()` was called. Fix by: 1. Capturing the current item *before* any async operations in `handleRemoveHistoryItem`, and restoring it afterwards if the item is still in history (i.e. it was not one of the removed items). Also add an explicit `setCurrentItem(current)` call before `reveal` to sync the internal state in case a deferred `onDidChangeSelection` changed it during the awaits. 2. Mocking `showInformationMessageWithAction` in the test to return immediately instead of calling the real VS Code API, which could trigger additional async event processing. Fixes the failing "Test (windows-latest)" CI job: QueryHistoryManager › handleRemoveHistoryItem › when the item is a variant analysis › when in progress › when the item being removed is not selected › should not change the selection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps js-yaml from 4.2.0 to 5.0.0.
Changelog
Sourced from js-yaml's changelog.
... (truncated)
Commits
75148bc5.0.0 released704b25dQuote document markers followed by whitespace42dea28Support complex !!pairs keys with realMapTag6cf374eFix dumping strings that collide with YAML markers65b8d94Clarify !!omap/!!pairs support33e3640Move tagname helpers tocommon/and remove unused exports4dd582bCleanup export types39b3792Add types export0cd01e9docs: update for v5c5a61a4Fix presenter coverageDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.