Skip to content

fix(collaboration): allow inactive users to be added as collaborators and team members#38156

Draft
lunny wants to merge 3 commits into
go-gitea:mainfrom
lunny:lunny/inactive_user_change
Draft

fix(collaboration): allow inactive users to be added as collaborators and team members#38156
lunny wants to merge 3 commits into
go-gitea:mainfrom
lunny:lunny/inactive_user_change

Conversation

@lunny

@lunny lunny commented Jun 18, 2026

Copy link
Copy Markdown
Member

Summary

Inactive users should remain unable to sign in, but otherwise be treated the same as regular users for collaboration and membership operations.

This PR removes the inactive-user restriction from collaborator and membership-related flows, so inactive users can still be added to repositories, teams, and other similar relationships.

Changes

  • allow inactive users to be added as repository collaborators via Web UI
  • allow inactive users to be added as repository collaborators via API
  • include inactive users in candidate user search results used by collaboration/member pickers
  • add regression tests for:
    • adding an inactive user as a collaborator
    • adding an inactive user as a team member
    • searching inactive users in collaboration candidate search

Behavior

Before:

  • inactive users could not be selected or added in some collaboration/member flows

After:

  • inactive users still cannot log in
  • inactive users can be added to collaborators, teams, and similar membership relationships like normal users

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 18, 2026
@lunny lunny added the type/enhancement An improvement of existing functionality label Jun 18, 2026
@bircni

bircni commented Jun 18, 2026

Copy link
Copy Markdown
Member

Is it then visible that the specific user is inactive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants