feat: add audit logging#38189
Open
bircni wants to merge 4 commits into
Open
Conversation
Member
Author
Notes
Still to come (follow-up commits)
|
Re-enables and ports the audit logging feature (originally proposed in go-gitea#24257), adapted to the current codebase. Records security-relevant events (user/org/repository/team changes, authentication, secrets, webhooks, keys) as structured GitHub-style events with an action, actor, scope, message and JSON metadata. Events can be written to the database and/or an audit log file, and are surfaced in admin, org, repo and user settings. This commit lands the audit infrastructure (models, service, settings, routes, templates, migration 340, locales) together with the first batch of ported call sites in services/repository, services/org and services/user, threading a doer through the affected service functions and their callers.
2bd2194 to
3863197
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-enables and ports the audit logging feature originally proposed in #24257, adapted to the current codebase. The original PR went stale; this revives it with a redesigned event model and incrementally re-wires the call sites.
Audit logging records security-relevant events as structured, GitHub-style events — each with an
action,actor,scope,message, and a JSONmetadatablob — rather than the original central type registry. Events can be persisted to the database and/or appended to an audit log file, and are surfaced in admin, organization, repository, and user settings.What's included
Infrastructure
models/audit/— event model + actionsservices/audit/—Record, entity-ref helpers (ActorFromUser,ScopeFrom*), DB + file writers,audit.Initmodules/setting/audit.go—[audit]config sectionv340anden-USlocale stringsadministration/audit-logging)Ported call sites (first batch)
services/repository— create/delete/fork/convert-fork, visibility, rename, transfer (start/finish/cancel), collaborators, team-repo add/remove, default branchservices/org— organization deleteservices/user— user delete, rename, delete-inactiveThese thread a
doerthrough the affected service functions and update all callers (web + API routers, CLI, cron, tests).