fix(workflows): branch protection status checks fail when workflow uses on: paths filter#38237
Open
Exgene wants to merge 7 commits into
Open
fix(workflows): branch protection status checks fail when workflow uses on: paths filter#38237Exgene wants to merge 7 commits into
Exgene wants to merge 7 commits into
Conversation
GiteaBot
added
the
lgtm/need 2
Member
|
could you fix the tests and conflicts? |
Contributor
Author
|
oh wonder why the tests are failing will report back |
Contributor
Author
Conflicts, should i create a merge commit? or any other workflow to be followed |
Member
yes please |
…status-filter # Conflicts: # services/actions/notifier_helper.go # services/actions/run.go
Contributor
Author
|
@bircni made the changes, I have updated test cases accordingly as well so let me know if you want any behavioral changes |
Member
|
will check |
bircni
approved these changes
Jun 30, 2026
GiteaBot
added
lgtm/need 1
Contributor
Author
|
right the grep did not find detectWorkflow, and maybe missed that change while merging |
Contributor
|
Some logic related to scoped workflows needs to be adjusted. I will check it and make some updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36895
Problem
When a workflow's event matches (e.g.
pull_requestorpush) but it is excluded bypaths,paths-ignore,branches, orbranches-ignore, no run was created. Because no run existed, no commit status was emitted, leaving required checks stuck atCommitStatusPending.Solution
detectNotApplicable,detectFilteredOutanddetectMatchedto differentiate between filters and not applicable.isForkPullRequestetc and then insert the payload throughPrepareRunAndInsertPrepareRunAndInsertto accommodate skipped workflows.Testing
Performed manual testing and skipped status check is shown
