chore: update node.js to v26#38285
Open
silverwind wants to merge 1 commit into
Open
Conversation
Bump the CI/build and dev-shell Node.js toolchain to v26, refresh @types/node to match, and refactor the release workflows to reuse the existing node-setup composite action instead of duplicating the pnpm + setup-node block (which previously required editing node-version in several coordinated spots). engines.node floor is left unchanged. Assisted-by: Claude:Opus 4.8
GiteaBot
added
the
lgtm/need 2
github-actions
Bot
added
the
skip-changelog
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Node.js toolchain to v26 across local development (Nix flake), frontend type dependencies, and GitHub Actions CI/release workflows, and centralizes Node/pnpm setup logic into a shared composite action.
Changes:
- Bump
@types/nodeto26.0.1and regeneratepnpm-lock.yamlto reflect the updated Node types and transitive dependencies. - Update the Nix dev shell to use
pkgs.nodejs_26and refreshflake.lockto a nixpkgs revision that supports the new toolchain. - Refactor release workflows to use the shared
.github/actions/node-setupcomposite action; update remaining direct setup to Node 26 where applicable.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Regenerates lockfile to align with @types/node@26.0.1 and updated transitive deps (e.g., undici-types). |
| package.json | Bumps @types/node devDependency to 26.0.1. |
| flake.nix | Switches dev shell Node toolchain from nodejs_24 to nodejs_26. |
| flake.lock | Updates pinned nixpkgs revision/hash to match the regenerated flake inputs needed for the Node bump. |
| .github/workflows/release-tag-version.yml | Uses the shared node-setup composite action instead of inline Node/pnpm setup. |
| .github/workflows/release-tag-rc.yml | Uses the shared node-setup composite action instead of inline Node/pnpm setup. |
| .github/workflows/release-nightly.yml | Uses the shared node-setup composite action instead of inline Node/pnpm setup. |
| .github/workflows/pull-labeler.yml | Updates actions/setup-node to Node 26 for PR title/label tooling. |
| .github/actions/node-setup/action.yml | Introduces/updates a composite action to standardize pnpm + Node 26 setup (with optional pnpm caching). |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bircni
reviewed
Jun 30, 2026
bircni
left a comment
bircni
left a comment
Member
There was a problem hiding this comment.
maybe we could use a .node-version file?
delvh
approved these changes
Jun 30, 2026
GiteaBot
added
lgtm/need 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@types/nodeto node 26