fix(actions): resolve workflow runs by run_number in API#38288
Open
afahey03 wants to merge 1 commit into
Open
Conversation
Contributor
|
I don't think it's necessary to add this fallback. Callers can get |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run-scoped Actions API handlers only resolved
{run}by database ID, while the web UI also accepts the repo-scopedrun_number(index). Callers who usedrun_numberfrom/actions/tasksor the UI URL could get an empty job list from GET/api/v1/repos/{owner}/{repo}/actions/runs/{run}/jobseven when jobs were visible in the browser. This PR adds the same ID-then-index fallback togetCurrentRepoActionRunByID, which is shared by run-scoped API endpoints including job listing.Test
ListRunJobsByRunNumberloads fixture run 795, which hasid795 andrun_number191, and callsGET /api/v1/repos/user2/repo2/actions/runs/191/jobs. It asserts the response is HTTP 200 with a non-zerototal_countand that job 198 is present in the list.Closes #38286