Fix resumed download average speed#1887
Open
ishaanlabs-gg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1516.
When resuming a download, the progress task starts at the existing byte offset. The completion summary was using that cumulative completed byte count for both:
That made resumed downloads report speed as if the already-present bytes were downloaded during the current invocation.
This change keeps the displayed total size cumulative, but subtracts the starting offset when calculating average speed. It applies to both the progress-bar display and the status display.
Validation:
2.5 bytes/sfor a resumed 2-byte transfer over 2 seconds.PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /Volumes/STOREJET/2/Dependencies/httpie/venv/bin/python -m pytest tests/test_downloads.py::TestDownloads::test_resumed_download_summary_uses_current_transfer_for_speed -qgit diff --checkNote:
/Volumes/STOREJET/2/Dependencies/httpie/venv..[test]extra is currently blocked locally by an old transitiveflasggerwheel build failure throughpytest-httpbin/httpbin, so I could not run the httpbin-backed download tests in this environment.