Skip to content

fix(git-node): add missing loop exit condition#1101

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:no-abort-on-cherry-pick-fail
Jun 29, 2026
Merged

fix(git-node): add missing loop exit condition#1101
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:no-abort-on-cherry-pick-fail

Conversation

@aduh95

@aduh95 aduh95 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

As it's currently written, if the commit is "clean" (i.e. contains only MD changes), the code stays in the while(true); loop until the user gives up.

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.52%. Comparing base (254ebaa) to head (90a2417).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1101   +/-   ##
=======================================
  Coverage   64.52%   64.52%           
=======================================
  Files          45       45           
  Lines        7003     7003           
=======================================
  Hits         4519     4519           
  Misses       2484     2484           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 merged commit 2d1085f into nodejs:main Jun 29, 2026
11 checks passed
@aduh95 aduh95 deleted the no-abort-on-cherry-pick-fail branch June 29, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants