Skip to content

build: suppress clang errors building libffi on Windows#64222

Open
Renegade334 wants to merge 1 commit into
nodejs:mainfrom
Renegade334:libffi-gyp
Open

build: suppress clang errors building libffi on Windows#64222
Renegade334 wants to merge 1 commit into
nodejs:mainfrom
Renegade334:libffi-gyp

Conversation

@Renegade334

Copy link
Copy Markdown
Member

After the latest libffi update, a macro is passing an int * as a long * in win32 builds, which makes clang unhappy.

Refs: #64040

Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/ffi
  • @nodejs/gyp
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jun 30, 2026
@Renegade334 Renegade334 added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Jun 30, 2026
@Renegade334 Renegade334 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 30, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 30, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. commit-queue Add this label to land a pull request using GitHub Actions. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants