OP-19605 Nothing happens when clicking project link in notification

[dfriquet]

Ticket

https://community.openproject.org/wp/OP-19605

What are you trying to accomplish?

Open links in workpackage split view as full-page navigation.

What approach did you choose and why?

Escape from Turbo Frame with target="_top".

Merge checklist

• Added/updated tests
• Added/updated documentation in Lookbook (patterns, previews, etc)
• Tested major browsers (Chrome, Firefox, Edge, ...)

[github-actions]

Caution

The provided work package version does not match the core version

Details:

• Work package URL: https://community.openproject.org/wp/OP-19605
• Work package version: 17.6.0
• Core version: 17.7.0

Please make sure that:

• The work package version OR your pull request target branch is correct

[github-actions]

Caution

The provided work package version does not match the core version

Details:

• Work package URL: https://community.openproject.org/wp/OP-19605
• Work package version: 17.6.0
• Core version: 17.7.0

Please make sure that:

• The work package version OR your pull request target branch is correct

[dfriquet]

I added this spec just to confirm my fix. I don’t know if it’s relevant enough to keep it and lengthen our feature specs runs, or if I drop it 🤷

[cbliard]

I would keep it. Just to prevent someone wondering why there is the target=_top", then try removing it, see it still works and push. This test is the only way to know something was broken (or on the contrary attest that the fix is not needed anymore).

[dfriquet]

In that case, a spec should exist for each and every _top link in this side panel. And some of them require quite a setup, like cost types, relationships and all… Resulting in slow repetitive tests.

I’ll try to fix it the other way around: all links trigger a full-page navigation, unless stated otherwise for ad-hoc in-frame navigation. That way, no need to test navigation except for the one that should stay on the same page 🤔

[github-actions]

Warning

Flaky specs

• rspec ./modules/gitlab_integration/spec/features/work_package_gitlab_tab_spec.rb[1:1:1:1:3]

🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #24017, linked for reference only):

- `rspec ./modules/gitlab_integration/spec/features/work_package_gitlab_tab_spec.rb[1:1:1:1:3]`

Treat this as a standalone task, unrelated to PR #24017. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #24017 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @dfriquet to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @dfriquet, and request a review from @dfriquet.
On every commit, set @dfriquet as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

[cbliard]

@dfriquet would it be possible to target release/17.6 branch so it's fixed for next release?

[cbliard]

I found two other places where the link is not working properly: user name link and sum query links

user name links

The "Update by " on top of the overview tab, clicking the user link triggers the bug (noop)

sum query links

If the work package has children and those children have work being set, then the parent shows the total, and this total is a link which can be clicked to show the children, so that the user can understand how the sum is computed.

When clicking this sum link from within the notification page in the work package side bar, then the link is a no-op.

Overall, it seems the fix is brittle: if a link is added in the overview page in the future, there is no guarantee this link will work properly when clicked from the notification center.