Update Redis::__construct options array shape#5952
Conversation
┌───────────────┬───────────────────────┐ │ property │ change │ ├───────────────┼───────────────────────┤ │ retryInterval │ added (int) │ ├───────────────┼───────────────────────┤ │ readTimeout │ added (float) │ ├───────────────┼───────────────────────┤ │ persistent │ added (bool|string) │ ├───────────────┼───────────────────────┤ │ database │ added (int) │ ├───────────────┼───────────────────────┤ │ auth │ added |string variant │ └───────────────┴───────────────────────┘
added missing comma
|
thanks for the PR. where did you find documentation for such options? |
|
After updating PHPStan (perhaps it's config has been made more strict, too, i Rebased an older PR in our project), it started reporting that the I first checked the documentation at https://github.com/phpredis/phpredis#user-content-class-redis
And one thing is likely wrong:
I didn't want to make the change too large, though, so I only added the keys that seemed most useful and added This should be a more complete/strict array shape if interested, could be used instead:
Or even more strict (the mentioned |
retryIntervalint)readTimeoutfloat)persistentbool|string)databaseint)maxRetriesint)auth|stringvariant