gh-134300: Remove idlelib from the path of the IDLE user process#152739
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-134300: Remove idlelib from the path of the IDLE user process#152739serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
The idlelib directory ends up on sys.path when idle.py is run as a script, and it was passed to the user process, where it let user code import idlelib submodules as top-level modules, such as "import help".
serhiy-storchaka
added
needs backport to 3.13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
idle.pyis run as a script, its directory (.../idlelib) is placed onsys.path[0].ModifiedInterpreter.transfer_path()then sends the whole GUIsys.pathto the user subprocess (replacing itssys.path), so user code could import idlelib submodules as top-level modules, e.g.import helpsilently importsidlelib.help. A subissue of #69674.transfer_path()now removes the idlelib directory from the transferred path. Only that entry is removed, soimport idlelib.runand the other idlelib modules the subprocess needs still resolve via theLibparent directory; as Terry noted in the issue,idlelib.runruns fine without idlelib on the path.The removal is factored into a module-level
fix_user_path()with a non-GUI unit test.🤖 Generated with Claude Code