gh-80504: Always show the full search path in IDLE Find in Files#152740
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-80504: Always show the full search path in IDLE Find in Files#152740serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
The "In files:" field of the Find in Files dialog now always contains a full directory path, so the grep output shows which directory was searched.
serhiy-storchaka
added
needs backport to 3.13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Find in Files is opened from an unsaved editor, the Shell, or an Output window,
io.filenameis empty, so the "In files:" field started as a bare*.py(os.path.join("", "*.py")). There was then no way to tell from the grep output which directory was actually searched.The pattern computation is factored into a module-level
default_glob()that makes the directory absolute (os.path.abspath, which maps""to the current directory and is idempotent on real paths), so the field always contains a full directory path. This matches what saved editor files already showed.Requested by Terry Reedy in the issue. The added non-GUI test covers the no-path, full-path, and non-
.pycases.🤖 Generated with Claude Code