gh-82183: Do not restart the busy IDLE shell when running without restart#152745
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-82183: Do not restart the busy IDLE shell when running without restart#152745serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
…ut restart "Run... Customized" with "Restart shell" unchecked restarted the shell anyway when it was busy executing code, killing any pending input. It now reports that the shell is executing and does not run.
serhiy-storchaka
added
needs backport to 3.13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AttributeErrorin the original report (bpo-38002) was fixed by bpo-42508. This addresses the remaining problem noted by @terryjreedy: with the Shell busy executing code (e.g. blocked oninput()), using "Run... Customized" with "Restart shell" unchecked restarted the subprocess anyway.run_module_eventskips the explicitrestart_subprocesswhen restart is unchecked, butruncodethen restarts the busy shell on its own, overriding the user's choice and killing the pending input.The new code cannot run in the busy shell's namespace without restarting it, so when restart is unchecked and the shell is executing it now reports "Already executing" and aborts, instead of restarting anyway.
🤖 Generated with Claude Code