gh-83637: Make IDLE calltip tests pass without docstrings#152746
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-83637: Make IDLE calltip tests pass without docstrings#152746serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Skip the tests that check docstrings with test.support.requires_docstrings, as test_inspect and test_pydoc do. They failed under -OO.
serhiy-storchaka
added
needs backport to 3.13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four
Get_argspectests intest_calltiphard-code expected docstrings in their output, so they fail under-OO(and would under a build without docstrings):test_builtins,test_methods,test_bound_methods, andtest_properly_formatted.Skip them with
test.support.requires_docstrings, astest_inspectandtest_pydocdo. This covers both-OO(Python docstrings stripped) andMISSING_C_DOCSTRINGSbuilds, sotest_builtinsmoves from@skipIf(MISSING_C_DOCSTRINGS)to the stronger@requires_docstrings.test_multiline_docstringkeeps@skipIf(MISSING_C_DOCSTRINGS)since it only needs C docstrings and already passes under-OO.Verified: normal run all pass;
-OOrun skips the four and reports no failures.🤖 Generated with Claude Code