gh-55646: Do not crash IDLE on an invalid key binding#152747
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-55646: Do not crash IDLE on an invalid key binding#152747serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
A typo in a key binding, such as <Alt-Key-up> for <Alt-Key-Up>, crashed IDLE at startup. It is now ignored with a warning.
serhiy-storchaka
added
needs backport to 3.13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A typo in a custom key binding entered via Advanced Key Binding (which is not validated), such as
<Alt-Key-up>instead of<Alt-Key-Up>, crashed IDLE at startup:File ".../idlelib/multicall.py", line ..., in bind self.__binders[triplet[1]].bind(triplet, func) ... _tkinter.TclError: bad event type or keysym "up"MultiCall.event_addstores the parsed sequence without validating the keysym, so theTclErroris raised later, when a virtual event is bound and MultiCall performs the actual Tkbind. With no window yet, IDLE just exits.Catch
TclErrorat both binder call sites (MultiCall.bindandMultiCall.event_add) and ignore the invalid binding with a warning naming it. Thebindpath also drops the bad sequence from the virtual event, which avoids a secondaryValueErrorif it is later rebound or unbound.🤖 Generated with Claude Code