gh-108280: Give a meaningful error for an invalid imaplib greeting#152768
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-108280: Give a meaningful error for an invalid imaplib greeting#152768serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Connecting to a server that does not send a valid IMAP4 greeting, such as a POP3 server answering on the IMAP port, failed with the unhelpful "imaplib.IMAP4.error: None". A meaningful message is now raised instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2 tasks
serhiy-storchaka
added
needs backport to 3.13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connecting
imaplibto a server that does not send a valid IMAP4 greeting-- for example a POP3 server answering on the IMAP port -- failed with the
unhelpful
imaplib.IMAP4.error: None.A
+OK ...greeting matches the continuation response pattern, so_get_response()returnsNoneandself.welcomeis left asNone. Theerror now reports the greeting the server actually sent, e.g.
invalid greeting: +OK POP3 server ready, so it is clear the peer is not anIMAP server. An untagged greeting such as
* BYE ...is reported likewise,and a bare continuation with no text yields
invalid greeting from server.imaplib.IMAP4.error: None#108280