Remove SafeAreaView from public API#57395
Open
zoontek wants to merge 3 commits into
Open
Conversation
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
Contributor
|
Thanks for working on this! We should follow the approach we've been following with other deprecated APIs. We should export a value in DEV that fails, and then remove it in a couple of releases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removes the deprecated public
SafeAreaViewcomponent (deprecated since 0.81). Usereact-native-safe-area-contextinstead.The native implementation is kept, since RN internals (LogBox, InputAccessoryView, element Inspector) still rely on it via
SafeAreaView_INTERNAL_DO_NOT_USE. The few internals that imported the public component now import the internal wrapper.See #57384
Changelog:
[GENERAL] [REMOVED] - Remove deprecated
SafeAreaViewcomponentTest Plan:
yarn flow-check: 0 errorsyarn test-typescript: passesyarn jest packages/react-native/Libraries/LogBox: passesrequire('react-native').SafeAreaViewisundefined