Skip to content

feat/default ci#44245

Draft
jamietanna wants to merge 5 commits into
mainfrom
feat/default-ci
Draft

feat/default ci#44245
jamietanna wants to merge 5 commits into
mainfrom
feat/default-ci

Conversation

@jamietanna

@jamietanna jamietanna commented Jun 26, 2026

Copy link
Copy Markdown
Contributor
  • test(util/exec): be more strict in expected value
  • rew! refactor
  • feat: always set CI=true for subprocesses

Changes

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

@jamietanna
test(util/exec): be more strict in expected value
600d89a 
As part of future changes, we'll introduce additional values, and we
want to make sure that this is strictly catching that addition.
@jamietanna
refactor(tools): extract function for basicEnvVars docs
cdff02b 
As we'll be adding more functionality into this file, and extracting the
function helps keep it clearer what's being done in the function scope.
@jamietanna
feat: always set CI=true for subprocesses
614bef8 
As noted in #43761, we had recently set `CI=true` for the Renovate and
Containerbase orgs on Mend-hosted apps due to a pnpm v11 requirement:

    ERR_PNPM_ABORTED_REMOVE_MODULES_DIR_NO_TTY  Aborted removal of
      modules directory due to no TTY

    If you are running pnpm in CI, set the CI environment variable to
      "true", or set "confirmModulesPurge" to "false".

Similarly in #43606, it was noted that we should do this for `mise lock`
to mark the workspace as "trusted".

Although we went with a different situation, there will be cases where
this is useful for tools being executed, for instance when we invoke `yarn`.

We also make sure to keep our documentation up-to-date as we add to the
specific overrides.
@jamietanna
refactor(manager/npm): remove redundant CI=true
ef8ef07 
As it's now the default.
@jamietanna
fixup! feat: always set CI=true for subprocesses
d2640f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jamietanna