test: Validate minimumReleaseAge is ignored for security updates#44272
Open
zharinov wants to merge 4 commits into
Open
test: Validate minimumReleaseAge is ignored for security updates#44272zharinov wants to merge 4 commits into
minimumReleaseAge is ignored for security updates#44272zharinov wants to merge 4 commits into
Conversation
zharinov
force-pushed
the
test/minimum-release-age-security-updates
branch
from
89be549 to
051dd25
Compare
…ypass Drive the real vulnerability flow (appendVulnerabilityPackageRules) through the real lookupUpdates, instead of only simulating the generated packageRule. Also reword the inline comment and use luxon/asTimestamp for timestamps.
zharinov
changed the title
minimumReleaseAge is ignored for security updates
Cast the spread config to satisfy partial() overload resolution, matching the existing `getConfig() as never` idiom in the lookup spec.
The simulated lookup test hand-built the security packageRule; the end-to-end test plus the generated-rule assertion in vulnerabilities.spec.ts cover the same behavior against the real flow, so the inline test added no unique coverage.
RahulGautamSingh
suggested changes
Jun 29, 2026
RahulGautamSingh
left a comment
RahulGautamSingh
left a comment
Collaborator
There was a problem hiding this comment.
lgtm except the one comment
| currentValue: dep.currentValue, | ||
| datasource: dep.datasource, | ||
| versioning: 'maven', | ||
| } as never); |
Collaborator
There was a problem hiding this comment.
currentValue: dep.currentValue ?? undefined,
this with a comment to fix the types of currentValue by removing null from it or adding null to other places its declared,.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add tests that prove
minimumReleaseAgeis skipped for security (vulnerability) updates.A security fix should not wait out the
minimumReleaseAgedelay. It already skips the delay becausevulnerabilityAlertsforcesminimumReleaseAge: nullonto the update. Nothing tested this, so two tests invulnerabilities.spec.tslock it down:force: { minimumReleaseAge: null }.appendVulnerabilityPackageRulesand thenlookupUpdates. A fix released yesterday is proposed right away with no pending status check, even withminimumReleaseAge: 14 daysandinternalChecksFilter: strict.Context
Please select one of the following:
minimumReleaseAgedoesn't apply to security updates #39061AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: N/A (unit tests only)