feat(config): detect and warn unwrapped regex#44285
Draft
RahulGautamSingh wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
managerFilePatterns(and other regex-or-glob options) accept both globs and regexes, where a regex must be wrapped in/.../. When a user writes a pattern that is clearly a regex but forgets the slashes, it is silently treated as a glob and never matches — with no feedback (see discussion #43741).This adds a config validation warning when an unwrapped matcher contains regex-only tokens (a
^start anchor, a$end anchor, or a\d/\w/\s/\bcharacter-class escape) that have no meaning in a glob, e.g.:It's a warning (not an error) because the heuristic can't be certain, and legitimate globs should keep working.
Context
Addresses discussion #43741
AI assistance disclosure
Documentation (please check one with an [x])
How I've tested my work (please select one)