Skip to content

fix(monorepo): group SPFx packages released together#44291

Open
exensio-rori wants to merge 1 commit into
renovatebot:mainfrom
exensio-rori:fix/spfx-monorepo
Open

fix(monorepo): group SPFx packages released together#44291
exensio-rori wants to merge 1 commit into
renovatebot:mainfrom
exensio-rori:fix/spfx-monorepo

Conversation

@exensio-rori

Copy link
Copy Markdown

Changes

Treat @microsoft/spfx-heft-plugins and @microsoft/spfx-web-build-rig as part of the SharePoint Framework, so they are updated together and avoid bad PR behavior.

See:
https://www.npmjs.com/package/@microsoft/spfx-heft-plugins
https://www.npmjs.com/package/@microsoft/spfx-web-build-rig

In the description of both packages, it says: "This package is part of the SharePoint Framework..."

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository: https://github.com/exensio-rori/renovate

@github-actions github-actions Bot requested a review from viceice June 29, 2026 16:04
@cla-assistant

cla-assistant Bot commented Jun 29, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Comment thread lib/data/monorepo.json
"@solid-design-system/components"
],
"spfx": ["/^@microsoft/sp-/", "/^@microsoft/eslint-.+-spfx$/"],
"spfx": ["/^@microsoft/sp-/", "/^@microsoft/spfx-(?!cli$)/", "/^@microsoft/eslint-.+-spfx$/"],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this won't work as expected because we use re2, which doesn't have backtracking, so look behind/ around and such things don't work.

@RahulGautamSingh RahulGautamSingh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public repo you shared doesn't make sense.

Reproduction to share, means you need to show that PRs were created.

Comment thread lib/data/monorepo.json
"@solid-design-system/components"
],
"spfx": ["/^@microsoft/sp-/", "/^@microsoft/eslint-.+-spfx$/"],
"spfx": ["/^@microsoft/sp-/", "/^@microsoft/spfx-(?!cli$)/", "/^@microsoft/eslint-.+-spfx$/"],

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"spfx": ["/^@microsoft/sp-/", "/^@microsoft/spfx-(?!cli$)/", "/^@microsoft/eslint-.+-spfx$/"],
"spfx": ["/^@microsoft/sp-/", "/^@microsoft/spfx-/", "!/^@microsoft/spfx-cli$/", "/^@microsoft/eslint-.+-spfx$/"],

use negation it's supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants