fix(monorepo): group SPFx packages released together#44291
Open
exensio-rori wants to merge 1 commit into
Open
Conversation
|
|
viceice
reviewed
Jun 29, 2026
| "@solid-design-system/components" | ||
| ], | ||
| "spfx": ["/^@microsoft/sp-/", "/^@microsoft/eslint-.+-spfx$/"], | ||
| "spfx": ["/^@microsoft/sp-/", "/^@microsoft/spfx-(?!cli$)/", "/^@microsoft/eslint-.+-spfx$/"], |
Member
There was a problem hiding this comment.
I'm pretty sure this won't work as expected because we use re2, which doesn't have backtracking, so look behind/ around and such things don't work.
RahulGautamSingh
left a comment
Collaborator
There was a problem hiding this comment.
The public repo you shared doesn't make sense.
Reproduction to share, means you need to show that PRs were created.
| "@solid-design-system/components" | ||
| ], | ||
| "spfx": ["/^@microsoft/sp-/", "/^@microsoft/eslint-.+-spfx$/"], | ||
| "spfx": ["/^@microsoft/sp-/", "/^@microsoft/spfx-(?!cli$)/", "/^@microsoft/eslint-.+-spfx$/"], |
Collaborator
There was a problem hiding this comment.
Suggested change
| "spfx": ["/^@microsoft/sp-/", "/^@microsoft/spfx-(?!cli$)/", "/^@microsoft/eslint-.+-spfx$/"], | |
| "spfx": ["/^@microsoft/sp-/", "/^@microsoft/spfx-/", "!/^@microsoft/spfx-cli$/", "/^@microsoft/eslint-.+-spfx$/"], |
use negation it's supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Treat @microsoft/spfx-heft-plugins and @microsoft/spfx-web-build-rig as part of the SharePoint Framework, so they are updated together and avoid bad PR behavior.
See:
https://www.npmjs.com/package/@microsoft/spfx-heft-plugins
https://www.npmjs.com/package/@microsoft/spfx-web-build-rig
In the description of both packages, it says: "This package is part of the SharePoint Framework..."
Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: https://github.com/exensio-rori/renovate