fix(cache): keep PR comment cache runtime-only#44296
Open
ag-linden wants to merge 2 commits into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Repository cache comment hashes are now treated as runtime-only state.
prCommentsentries when repository cache data is loadedprCommentsentries when repository cache data is savedensureComment()Context
ensureComment()usesrepoCache.prCommentsto avoid repeating the same platform comment write for the same PR/topic/content hash.That is fine as a runtime optimization, but repository cache can also be persisted across runs.
When a hash from a previous run is restored, Renovate can treat the cached hash as proof that the remote platform comment still exists and still has the expected body.
Platform comments are mutable remote state, so they can be edited or deleted outside Renovate.
If that happens while the persisted hash still matches the desired content, Renovate skips
platform.ensureComment()and returns success without re-checking the remote comment.This keeps the cache useful inside one run, while avoiding carrying comment assurance state across runs.
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: N/A
Validation run locally with Node 24.18.0 and pnpm 11.8.0:
pnpm vitest lib/util/cache/repository/impl/local.spec.ts --coverage=falsepnpm vitest lib/modules/platform/comment.spec.ts --coverage=falsepnpm check lib/util/cache/repository/impl/base.ts lib/util/cache/repository/impl/local.spec.tspnpm type-checkpnpm test-schemaI also tried the full
pnpm testgate.It stopped before patch-related tests at local
ls-lint; standalonels-lintexits without diagnostics, the direct darwin-arm64 binary exits 137, and local metadata checks for that binary reportOperation not permitted.