Skip to content

feat: add support for fully qualified urls for Mint packages#44305

Open
kronenthaler wants to merge 1 commit into
renovatebot:mainfrom
kronenthaler:main
Open

feat: add support for fully qualified urls for Mint packages#44305
kronenthaler wants to merge 1 commit into
renovatebot:mainfrom
kronenthaler:main

Conversation

@kronenthaler

@kronenthaler kronenthaler commented Jun 30, 2026

Copy link
Copy Markdown

Changes

Mintfiles support fully qualified urls to specify swift dependencies (some might be in bitbucket or in on-premise hosted git repos)
The current mint manager was constructing blindly a url prefixing https://github.com/ creating weird and incorrect urls e.g.
https://github.com/https://bitbucket.org/atlassian/swift-http-server.git.git

This PR allows the manager to detect fully qualified urls and pass them as they are defined.

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

@github-actions github-actions Bot requested a review from viceice June 30, 2026 15:18
@cla-assistant

cla-assistant Bot commented Jun 30, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@cla-assistant

cla-assistant Bot commented Jun 30, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

let depName = depDefinition;
let packageName = `https://github.com/${depName}.git`;

if (depDefinition.startsWith('http')) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can cause false positive if a normal dep starts with http

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants