feat: add support for fully qualified urls for Mint packages#44305
Open
kronenthaler wants to merge 1 commit into
Open
feat: add support for fully qualified urls for Mint packages#44305kronenthaler wants to merge 1 commit into
kronenthaler wants to merge 1 commit into
Conversation
|
|
viceice
reviewed
Jun 30, 2026
| let depName = depDefinition; | ||
| let packageName = `https://github.com/${depName}.git`; | ||
|
|
||
| if (depDefinition.startsWith('http')) { |
Member
There was a problem hiding this comment.
this can cause false positive if a normal dep starts with http
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Mintfiles support fully qualified urls to specify swift dependencies (some might be in bitbucket or in on-premise hosted git repos)
The current mint manager was constructing blindly a url prefixing
https://github.com/creating weird and incorrect urls e.g.https://github.com/https://bitbucket.org/atlassian/swift-http-server.git.gitThis PR allows the manager to detect fully qualified urls and pass them as they are defined.
Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: