fix(manager/swift): don't rewrite Package.resolved pins in unrelated packages#44317
Open
fxwx23 wants to merge 1 commit into
Open
fix(manager/swift): don't rewrite Package.resolved pins in unrelated packages#44317fxwx23 wants to merge 1 commit into
fxwx23 wants to merge 1 commit into
Conversation
…packages For exact (single-version) specs, only update a pin whose current version matches the version being upgraded from. This prevents the repo-wide Package.resolved sweep from rewriting a same-named transitive pin in an unrelated package to a version that package's constraints don't allow.
694a7f5 to
42ff70f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
For exact (single-version) specs, only update a pin whose current version matches the version being upgraded from. This prevents the repo-wide Package.resolved sweep from rewriting a same-named transitive pin in an unrelated package to a version that package's constraints don't allow.
Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.
Used Claude (via Claude Code): Claude Opus 4.8 for the investigation, the fix design, and drafting the code/tests; Claude Sonnet 5 for applying the changes to the working tree and running the test/lint verification. All output was reviewed by a human before submission.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
The public repository: