VT100 support for SmallBASIC console#287
Conversation
chrisws
left a comment
chrisws
left a comment
There was a problem hiding this comment.
It looks really good, just a few minor fixes. Have you tested this with raylib etc?
| EXTERN byte opt_antialias; /**< OPTION ANTIALIAS OFF */ | ||
| EXTERN byte opt_autolocal; /**< OPTION AUTOLOCAL */ | ||
| EXTERN byte opt_trace_on; /**< initial value for the TRON command */ | ||
| EXTERN byte opt_vt100; /**< disable VT100 in console */ |
There was a problem hiding this comment.
These variables are for the executor. I think opt_vt100 could just be defined in the console code somewhere directly. It has no purpose for the other platforms.
There was a problem hiding this comment.
I removed opt_vt100 in smbas.h and defined it in console/main.cpp
| dev_initfs(); | ||
| dev_fgcolor = 0; | ||
| dev_bgcolor = (os_graphics) ? 15 : 0; | ||
| dev_fgcolor = 15; |
There was a problem hiding this comment.
would it work just the same now if this change was reverted? It might change change one of the other platforms in someway.
There was a problem hiding this comment.
yes it works. I reverted the changes.
| // | ||
| void dev_setcolor(long color) { | ||
| if (color <= 15 && color >= 0) { | ||
| /*if (color <= 15 && color >= 0) { |
There was a problem hiding this comment.
maybe use the #ifdef for console use here. don't leave the commented out code.
There was a problem hiding this comment.
I used #ifdef. I tried to understand how osd_setcolor is used. I think the if-else-statement is not necessary but I'm not 100% sure.
| return 0; | ||
| } | ||
|
|
||
| #if USE_TERM_IO || defined (_Win32) |
There was a problem hiding this comment.
could this be simplified to just #if USE_TERM_IO ? it could be defined in the configure script when building for windows.
There was a problem hiding this comment.
I don't think this can be simplified. If USE_TERM_IO is defined for windows, then in device.cpp the Linux code will be build in windows (see line 133 and 219).
|
Raylib works with and without the |
2 participants
No description provided.