fix: make set_key export output shell-safe#670
Open
j0m0k0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes
set_key(..., export=True)safer when it writes shell-style.envlines.When
export=Trueis used, python-dotenv writes output intended to be usable by a shell, for example withsource .env. Before this change, a value containing a single quote, or an invalid key name containing shell syntax, could make the generated file run a command when sourced.Changes
Related
Related to #543 and #647. That PR handles values containing single quotes, but it does not cover unsafe key names. This PR also keeps the fix focused on the
export=Trueshell-output path.