chore: enable unused-vars and import lint rules

.github/workflows/code-quality.yml

@@ -8,7 +8,7 @@ permissions:
 
 jobs:
   code-quality:
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-2vcpu-ubuntu-2404
 
     steps:
       - name: ⬇️ Checkout repo

.github/workflows/docs.yml

@@ -20,7 +20,7 @@ permissions:
 
 jobs:
   check-broken-links:
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-2vcpu-ubuntu-2404
     defaults:
       run:
         working-directory: ./docs

.github/workflows/e2e-webapp-auth-full.yml

@@ -37,7 +37,7 @@ on:
 jobs:
   e2eAuthFull:
     name: "🛡️ E2E Auth Tests (full)"
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-8vcpu-ubuntu-2404
     timeout-minutes: 30
     env:
       DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}

.github/workflows/e2e-webapp.yml

@@ -14,7 +14,7 @@ on:
 jobs:
   e2eTests:
     name: "🧪 E2E Tests: Webapp"
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-8vcpu-ubuntu-2404
     timeout-minutes: 20
     env:
       DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}

.github/workflows/e2e.yml

@@ -20,7 +20,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, windows-latest]
+        os: [blacksmith-4vcpu-ubuntu-2404, blacksmith-4vcpu-windows-2025]
         package-manager: ["npm", "pnpm"]
     steps:
       - name: ⬇️ Checkout repo

.github/workflows/helm-prerelease.yml

@@ -28,7 +28,7 @@ env:
 
 jobs:
   lint-and-test:
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-2vcpu-ubuntu-2404
     permissions:
       contents: read
     steps:
@@ -77,7 +77,7 @@ jobs:
       ((github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository) ||
       github.event_name == 'push' ||
       github.event_name == 'workflow_dispatch')
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-4vcpu-ubuntu-2404
     permissions:
       contents: read
       packages: write

.github/workflows/publish-webapp.yml

@@ -38,7 +38,7 @@ on:
 
 jobs:
   publish:
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-8vcpu-ubuntu-2404
     env:
       PRISMA_ENGINES_CHECKSUM_IGNORE_MISSING: 1
     outputs:

.github/workflows/publish-worker-v4.yml

@@ -37,7 +37,7 @@ jobs:
     strategy:
       matrix:
         package: [supervisor]
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-8vcpu-ubuntu-2404
     env:
       DOCKER_BUILDKIT: "1"
     steps:

.github/workflows/publish-worker.yml

@@ -33,7 +33,7 @@ jobs:
     strategy:
       matrix:
         package: [coordinator, docker-provider, kubernetes-provider]
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-8vcpu-ubuntu-2404
     env:
       DOCKER_BUILDKIT: "1"
       DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }}

.github/workflows/sdk-compat.yml

@@ -13,7 +13,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest]
+        os: [blacksmith-4vcpu-ubuntu-2404]
         node: ["20.20", "22.12"]
 
     steps:
@@ -54,7 +54,7 @@ jobs:
 
   bun-compat:
     name: "Bun Runtime"
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-4vcpu-ubuntu-2404
     steps:
       - name: ⬇️ Checkout repo
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -96,7 +96,7 @@ jobs:
 
   deno-compat:
     name: "Deno Runtime"
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-4vcpu-ubuntu-2404
     steps:
       - name: ⬇️ Checkout repo
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
@@ -142,7 +142,7 @@ jobs:
 
   cloudflare-compat:
     name: "Cloudflare Workers"
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-4vcpu-ubuntu-2404
     steps:
       - name: ⬇️ Checkout repo
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

.github/workflows/trivy-image-webapp.yml

@@ -33,7 +33,7 @@ concurrency:
 jobs:
   scan:
     name: Scan
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-2vcpu-ubuntu-2404
     permissions:
       contents: read
       packages: read # pull the image from GHCR

.github/workflows/typecheck.yml

@@ -8,7 +8,7 @@ permissions:
 
 jobs:
   typecheck:
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-8vcpu-ubuntu-2404
 
     steps:
       - name: ⬇️ Checkout repo

.github/workflows/unit-tests-internal.yml

@@ -14,7 +14,7 @@ on:
 jobs:
   unitTests:
     name: "🧪 Unit Tests: Internal"
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-8vcpu-ubuntu-2404
     strategy:
       # one flaky shard shouldn't cancel its siblings - lets us re-run only the failed shard
       fail-fast: false
@@ -130,7 +130,7 @@ jobs:
     name: "📊 Merge Reports"
     if: ${{ !cancelled() }}
     needs: [unitTests]
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-2vcpu-ubuntu-2404
     steps:
       - name: ⬇️ Checkout repo
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

.github/workflows/unit-tests-packages.yml

@@ -14,7 +14,7 @@ on:
 jobs:
   unitTests:
     name: "🧪 Unit Tests: Packages"
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-4vcpu-ubuntu-2404
     strategy:
       # one flaky shard shouldn't cancel its siblings - lets us re-run only the failed shard
       fail-fast: false
@@ -130,7 +130,7 @@ jobs:
     name: "📊 Merge Reports"
     if: ${{ !cancelled() }}
     needs: [unitTests]
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-2vcpu-ubuntu-2404
     steps:
       - name: ⬇️ Checkout repo
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

.github/workflows/unit-tests-webapp.yml

@@ -14,7 +14,7 @@ on:
 jobs:
   unitTests:
     name: "🧪 Unit Tests: Webapp"
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-8vcpu-ubuntu-2404
     strategy:
       # one flaky shard shouldn't cancel its siblings - lets us re-run only the failed shard
       fail-fast: false
@@ -139,7 +139,7 @@ jobs:
     name: "📊 Merge Reports"
     if: ${{ !cancelled() }}
     needs: [unitTests]
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-2vcpu-ubuntu-2404
     steps:
       - name: ⬇️ Checkout repo
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

.github/workflows/workflow-checks.yml

@@ -24,7 +24,7 @@ concurrency:
 jobs:
   actionlint:
     name: Actionlint
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-2vcpu-ubuntu-2404
     permissions:
       contents: read
     steps:
@@ -43,7 +43,7 @@ jobs:
     # variable to 'false' to skip this job where code scanning isn't available;
     # leave it unset (the default) to run the scan.
     if: ${{ vars.ENABLE_WORKFLOW_SECURITY_SCAN != 'false' }}
-    runs-on: ubuntu-latest
+    runs-on: blacksmith-2vcpu-ubuntu-2404
     permissions:
       security-events: write # Upload SARIF to GitHub Security tab
       contents: read # Read workflow files for analysis

.oxlintrc.json

@@ -11,13 +11,23 @@
     "internal-packages/tsql/src/grammar/"
   ],
   "rules": {
-    "no-unused-vars": "off",
+    "no-unused-vars": [
+      "error",
+      {
+        "args": "all",
+        "argsIgnorePattern": "^_",
+        "varsIgnorePattern": "^_",
+        "caughtErrors": "all",
+        "caughtErrorsIgnorePattern": "^_",
+        "destructuredArrayIgnorePattern": "^_"
+      }
+    ],
     "no-empty-pattern": "off",
     "no-control-regex": "off",
     "typescript/no-non-null-asserted-optional-chain": "off",
     "no-unused-expressions": ["warn", { "allowShortCircuit": true, "allowTernary": true }],
-    "typescript/consistent-type-imports": "off",
-    "import/no-duplicates": "off",
+    "typescript/consistent-type-imports": "error",
+    "import/no-duplicates": "error",
     "import/namespace": "off",
     "react-hooks/exhaustive-deps": "off",
     "react-hooks/rules-of-hooks": "off"

apps/coordinator/src/checkpointer.ts

@@ -334,7 +334,7 @@ export class Checkpointer {
 
       try {
         await setTimeout(delayMs, undefined, { signal });
-      } catch (error) {
+      } catch (_error) {
         this.#logger.log("Checkpoint canceled during initial delay", { runId });
         return { success: false, reason: "CANCELED" };
       }
@@ -364,7 +364,7 @@ export class Checkpointer {
 
           try {
             await setTimeout(delay.milliseconds, undefined, { signal });
-          } catch (error) {
+          } catch (_error) {
             this.#logger.log("Checkpoint canceled during retry delay", { runId });
             return { success: false, reason: "CANCELED" };
           }

apps/coordinator/src/exec.ts

@@ -208,7 +208,7 @@ export class Buildah {
     try {
       await x("buildah", ["login", "--get-login", registryHost], { throwOnError: true });
       return true;
-    } catch (error) {
+    } catch (_error) {
       return false;
     }
   }

apps/coordinator/src/index.ts

@@ -1,13 +1,13 @@
 import { createServer } from "node:http";
 import { Server } from "socket.io";
+import type { WaitReason } from "@trigger.dev/core/v3";
 import {
   CoordinatorToPlatformMessages,
   CoordinatorToProdWorkerMessages,
   omit,
   PlatformToCoordinatorMessages,
   ProdWorkerSocketData,
   ProdWorkerToCoordinatorMessages,
-  WaitReason,
 } from "@trigger.dev/core/v3";
 import { ZodNamespace } from "@trigger.dev/core/v3/zodNamespace";
 import { ZodSocketConnection } from "@trigger.dev/core/v3/zodSocket";
@@ -423,7 +423,7 @@ class TaskCoordinator {
 
         next();
       },
-      onConnection: async (socket, handler, sender) => {
+      onConnection: async (socket, _handler, _sender) => {
         const logger = new SimpleStructuredLogger("ns-prod-worker", undefined, {
           namespace: "prod-worker",
           socketId: socket.id,
@@ -1456,7 +1456,7 @@ class TaskCoordinator {
           }
         });
       },
-      onDisconnect: async (socket, handler, sender, logger) => {
+      onDisconnect: async (socket, _handler, _sender, logger) => {
         try {
           this.#platformSocket?.send("LOG", {
             metadata: socket.data,
@@ -1529,7 +1529,7 @@ class TaskCoordinator {
       }
     });
 
-    httpServer.on("clientError", (err, socket) => {
+    httpServer.on("clientError", (_err, socket) => {
       socket.end("HTTP/1.1 400 Bad Request\r\n\r\n");
     });
 
@@ -1760,7 +1760,7 @@ class TaskCoordinator {
       }
     });
 
-    httpServer.on("clientError", (err, socket) => {
+    httpServer.on("clientError", (_err, socket) => {
       socket.end("HTTP/1.1 400 Bad Request\r\n\r\n");
     });
 

apps/coordinator/src/util.ts

@@ -25,7 +25,7 @@ export function safeJsonParse(json?: string): unknown {
 
   try {
     return JSON.parse(json);
-  } catch (e) {
+  } catch (_e) {
     return null;
   }
 }

apps/docker-provider/src/index.ts

@@ -1,16 +1,14 @@
 import { $, type ExecaChildProcess, execa } from "execa";
-import {
-  ProviderShell,
+import type {
   TaskOperations,
   TaskOperationsCreateOptions,
   TaskOperationsIndexOptions,
   TaskOperationsRestoreOptions,
 } from "@trigger.dev/core/v3/apps";
-import { SimpleLogger } from "@trigger.dev/core/v3/apps";
-import { isExecaChildProcess } from "@trigger.dev/core/v3/apps";
+import { ProviderShell, SimpleLogger, isExecaChildProcess } from "@trigger.dev/core/v3/apps";
 import { testDockerCheckpoint } from "@trigger.dev/core/v3/serverOnly";
 import { setTimeout } from "node:timers/promises";
-import { PostStartCauses, PreStopCauses } from "@trigger.dev/core/v3";
+import type { PostStartCauses, PreStopCauses } from "@trigger.dev/core/v3";
 
 const MACHINE_NAME = process.env.MACHINE_NAME || "local";
 const COORDINATOR_PORT = process.env.COORDINATOR_PORT || 8020;
@@ -192,7 +190,7 @@ class DockerTaskOperations implements TaskOperations {
     logger.log("noop: delete");
   }
 
-  async get(opts: { runId: string }) {
+  async get(_opts: { runId: string }) {
     await this.init();
 
     logger.log("noop: get");